linux-kernel - Re:Re: [PATCH] Fix missing 'bit' in comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <APYA*ADSCJWJ*JO7xH64KaqT.3.1584063328152.Hmail.luochucheng@vivo.com>
Date:   Fri, 13 Mar 2020 09:35:28 +0800 (GMT+08:00)
From:   罗楚成 <luochucheng@...o.com>
To:     Andreas Dilger <adilger@...ger.ca>
Cc:     Hans de Goede <hdegoede@...hat.com>,
        Linux FS Devel <linux-fsdevel@...r.kernel.org>,
        linux-kernel@...r.kernel.org, wenhu.wang@...o.com,
        trivial@...nel.org
Subject: Re:Re: [PATCH] Fix missing 'bit' in comment

That sounds reasonable. I will submit a new patch based on '32-bit' and '64-bit'

From: Andreas Dilger <adilger@...ger.ca>
Date: 2020-03-13 05:27:48
To:  Hans de Goede <hdegoede@...hat.com>
Cc:  Chucheng Luo <luochucheng@...o.com>,Linux FS Devel <linux-fsdevel@...r.kernel.org>,linux-kernel@...r.kernel.org,wenhu.wang@...o.com,trivial@...nel.org
Subject: Re: [PATCH] Fix missing 'bit' in comment>On Mar 12, 2020, at 4:40 AM, Hans de Goede <hdegoede@...hat.com> wrote:
>> 
>> Hi,
>> 
>> On 3/12/20 8:40 AM, Chucheng Luo wrote:
>>> The missing word may make it hard for other developers to
>>> understand it.
>>> Signed-off-by: Chucheng Luo <luochucheng@...o.com>
>> 
>> Thanks for catching this:
>> 
>> Acked-by: Hans de Goede <hdegoede@...hat.com>
>
>Not to nit-pick, but these should properly be written as "32-bit" and "64-bit".
>That can be easily fixed in the patch before upstream submission.
>
>Cheers, Andreas
>
>> Regards,
>> 
>> Hans
>> 
>> 
>>> ---
>>>  fs/vboxsf/dir.c | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>> diff --git a/fs/vboxsf/dir.c b/fs/vboxsf/dir.c
>>> index dd147b490982..be4f72625d36 100644
>>> --- a/fs/vboxsf/dir.c
>>> +++ b/fs/vboxsf/dir.c
>>> @@ -134,7 +134,7 @@ static bool vboxsf_dir_emit(struct file *dir, struct dir_context *ctx)
>>>  		d_type = vboxsf_get_d_type(info->info.attr.mode);
>>>    		/*
>>> -		 * On 32 bit systems pos is 64 signed, while ino is 32 bit
>>> +		 * On 32 bit systems pos is 64 bit signed, while ino is 32 bit
>>>  		 * unsigned so fake_ino may overflow, check for this.
>>>  		 */
>>>  		if ((ino_t)(ctx->pos + 1) != (u64)(ctx->pos + 1)) {
>> 
>
>
>Cheers, Andreas
>
>
>
>
>