linux-kernel - Re: [PATCH -next] rcu-tasks: fix a modpost warning for rcu_tasks_rude_wait

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200313134947.GP3199@paulmck-ThinkPad-P72>
Date:   Fri, 13 Mar 2020 06:49:47 -0700
From:   "Paul E. McKenney" <paulmck@...nel.org>
To:     Qiujun Huang <hqjagain@...il.com>
Cc:     josh@...htriplett.org, rostedt@...dmis.org,
        mathieu.desnoyers@...icios.com, jiangshanlai@...il.com,
        joel@...lfernandes.org, rcu@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] rcu-tasks: fix a modpost warning for
 rcu_tasks_rude_wait_gp

On Fri, Mar 13, 2020 at 07:38:10PM +0800, Qiujun Huang wrote:
> Found by gcc:
> WARNING: modpost: "rcu_tasks_rude_wait_gp" [vmlinux] is a static
> EXPORT_SYMBOL_GPL
> 
> Signed-off-by: Qiujun Huang <hqjagain@...il.com>

Good eyes, thank you!

However, the fix is instead to remove the EXPORT_SYMBOL_GPL().  I will
squash the removal of this line into a04838a348a9 ("rcu-tasks: Add an
RCU-tasks rude variant"), crediting you with catching this bug.

Again, thank you!

							Thanx, Paul

> ---
>  kernel/rcu/tasks.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/rcu/tasks.h b/kernel/rcu/tasks.h
> index cd071b5d4274..04d3c583a9fc 100644
> --- a/kernel/rcu/tasks.h
> +++ b/kernel/rcu/tasks.h
> @@ -447,7 +447,7 @@ static void rcu_tasks_be_rude(struct work_struct *work)
>  }
>  
>  // Wait for one rude RCU-tasks grace period.
> -static void rcu_tasks_rude_wait_gp(struct rcu_tasks *rtp)
> +void rcu_tasks_rude_wait_gp(struct rcu_tasks *rtp)
>  {
>  	schedule_on_each_cpu(rcu_tasks_be_rude);
>  }
> -- 
> 2.17.1
>