[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <alpine.LSU.2.21.2003131500100.30076@pobox.suse.cz>
Date: Fri, 13 Mar 2020 15:00:42 +0100 (CET)
From: Miroslav Benes <mbenes@...e.cz>
To: Josh Poimboeuf <jpoimboe@...hat.com>
cc: x86@...nel.org, linux-kernel@...r.kernel.org,
Peter Zijlstra <peterz@...radead.org>,
Vince Weaver <vincent.weaver@...ne.edu>,
Dave Jones <dsj@...com>, Jann Horn <jannh@...gle.com>,
Andy Lutomirski <luto@...nel.org>,
Steven Rostedt <rostedt@...dmis.org>,
Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH 00/14] x86/unwind/orc: ORC fixes
On Thu, 12 Mar 2020, Josh Poimboeuf wrote:
> Several ORC unwinder cleanups, fixes, and debug improvements.
>
> Jann Horn (1):
> x86/entry/64: Fix unwind hints in rewind_stack_do_exit()
>
> Josh Poimboeuf (12):
> x86/dumpstack: Add SHOW_REGS_IRET mode
> objtool: Fix stack offset tracking for indirect CFAs
> x86/entry/64: Fix unwind hints in register clearing code
> x86/entry/64: Fix unwind hints in kernel exit path
> x86/entry/64: Fix unwind hints in __switch_to_asm()
> x86/unwind/orc: Convert global variables to static
> x86/unwind: Prevent false warnings for non-current tasks
> x86/unwind/orc: Prevent unwinding before ORC initialization
> x86/unwind/orc: Fix error path for bad ORC entry type
> x86/unwind/orc: Fix premature unwind stoppage due to IRET frames
> x86/unwind/orc: Add more unwinder warnings
> x86/unwind/orc: Add 'unwind_debug' cmdline option
>
> Miroslav Benes (1):
> x86/unwind/orc: Don't skip the first frame for inactive tasks
>
> .../admin-guide/kernel-parameters.txt | 6 +
> arch/x86/entry/calling.h | 40 ++--
> arch/x86/entry/entry_64.S | 14 +-
> arch/x86/include/asm/kdebug.h | 1 +
> arch/x86/include/asm/unwind.h | 2 +-
> arch/x86/kernel/dumpstack.c | 27 +--
> arch/x86/kernel/dumpstack_64.c | 3 +-
> arch/x86/kernel/process_64.c | 7 +-
> arch/x86/kernel/unwind_frame.c | 3 +
> arch/x86/kernel/unwind_orc.c | 185 ++++++++++++++----
> tools/objtool/check.c | 2 +-
> 11 files changed, 201 insertions(+), 89 deletions(-)
Apart from the two nits I mentioned and Jann's comment on comment, it
looks good to me.
Reviewed-by: Miroslav Benes <mbenes@...e.cz>
M
Powered by blists - more mailing lists