linux-kernel - Re: [PATCH 2/4] usb: xhci: xhci-plat: Add support for Broadcom STB SoC's

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200313145846.GU1922688@smile.fi.intel.com>
Date:   Fri, 13 Mar 2020 16:58:46 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Al Cooper <alcooperx@...il.com>
Cc:     linux-kernel@...r.kernel.org,
        Alan Stern <stern@...land.harvard.edu>,
        Arnd Bergmann <arnd@...db.de>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        bcm-kernel-feedback-list@...adcom.com,
        "David S. Miller" <davem@...emloft.net>,
        devicetree@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Johan Hovold <johan@...nel.org>,
        Jonathan Cameron <Jonathan.Cameron@...wei.com>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        linux-usb@...r.kernel.org, Mark Rutland <mark.rutland@....com>,
        Mathias Nyman <mathias.nyman@...el.com>,
        Mauro Carvalho Chehab <mchehab+huawei@...nel.org>,
        Rob Herring <robh+dt@...nel.org>, Rob Herring <robh@...nel.org>
Subject: Re: [PATCH 2/4] usb: xhci: xhci-plat: Add support for Broadcom STB
 SoC's

On Fri, Mar 13, 2020 at 10:15:43AM -0400, Al Cooper wrote:
> Add support for Broadcom STB SoC's to the xhci platform driver

...

>  #include "xhci-plat.h"
>  #include "xhci-mvebu.h"
>  #include "xhci-rcar.h"
> +#include "xhci-brcm.h"

Perhaps put it in order, i.e. after xhci-plat.h?

...

> +static const struct xhci_plat_priv xhci_plat_brcm = {
> +	.init_quirk = xhci_plat_brcm_init_quirk

Add comma at the end, it might help to reduce burden on update.

> +};

-- 
With Best Regards,
Andy Shevchenko