linux-kernel - Re: [PATCH v3] thermal: devfreq_cooling: Use PM QoS to set frequency limits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200313165535.GI144492@google.com>
Date:   Fri, 13 Mar 2020 09:55:35 -0700
From:   Matthias Kaehlcke <mka@...omium.org>
To:     MyungJoo Ham <myungjoo.ham@...sung.com>,
        Kyungmin Park <kyungmin.park@...sung.com>,
        Chanwoo Choi <cw00.choi@...sung.com>,
        Zhang Rui <rui.zhang@...el.com>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Amit Kucheria <amit.kucheria@...durent.com>,
        Lukasz Luba <lukasz.luba@....com>
Cc:     linux-kernel@...r.kernel.org,
        Leonard Crestez <leonard.crestez@....com>,
        linux-pm@...r.kernel.org
Subject: Re: [PATCH v3] thermal: devfreq_cooling: Use PM QoS to set frequency
 limits

On Thu, Mar 12, 2020 at 11:34:20AM -0700, Matthias Kaehlcke wrote:
> Now that devfreq supports limiting the frequency range of a device
> through PM QoS make use of it instead of disabling OPPs that should
> not be used.
> 
> The switch from disabling OPPs to PM QoS introduces a subtle behavioral
> change in case of conflicting requests (min > max): PM QoS gives
> precedence to the MIN_FREQUENCY request, while higher OPPs disabled
> with dev_pm_opp_disable() would override MIN_FREQUENCY.
> 
> Signed-off-by: Matthias Kaehlcke <mka@...omium.org>
> Reviewed-by: Lukasz Luba <lukasz.luba@....com>

I just noticed that I forgot to add Chanwoo's 'Reviewed-by' tag from v2.
Dunno if patchwork will allow this, but I can try:

Reviewed-by: Chanwoo Choi <cw00.choi@...sung.com>