linux-kernel - Re: [PATCH 07/16] soundwire: cadence: mask Slave interrupt before stopping clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4b7d3e8c-b803-c6ae-3072-93f8187604c4@linux.intel.com>
Date:   Fri, 13 Mar 2020 11:33:53 -0500
From:   Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
To:     Vinod Koul <vkoul@...nel.org>
Cc:     alsa-devel@...a-project.org, tiwai@...e.de,
        gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
        Ranjani Sridharan <ranjani.sridharan@...ux.intel.com>,
        Hui Wang <hui.wang@...onical.com>, broonie@...nel.org,
        srinivas.kandagatla@...aro.org, jank@...ence.com,
        slawomir.blauciak@...el.com, Sanyog Kale <sanyog.r.kale@...el.com>,
        Bard liao <yung-chuan.liao@...ux.intel.com>,
        Rander Wang <rander.wang@...ux.intel.com>
Subject: Re: [PATCH 07/16] soundwire: cadence: mask Slave interrupt before
 stopping clock


>> +/**
>> + * sdw_cdns_enable_slave_interrupt() - Enable SDW slave interrupts
>> + * @cdns: Cadence instance
>> + * @state: boolean for true/false
>> + */
>> +static void cdns_enable_slave_interrupts(struct sdw_cdns *cdns, bool state)
> 
> Do you want to rename this as cdns_configure_slave_interrupts, with
> argument as enable/disable... ?

this follows the convention we already have with:

int sdw_cdns_enable_interrupt(struct sdw_cdns *cdns, bool state);

but it just deals with slave interrupts only.