lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 14 Mar 2020 02:17:38 +0800 (GMT+08:00) From: 王文虎 <wenhu.wang@...o.com> To: Christophe Leroy <christophe.leroy@....fr> Cc: Benjamin Herrenschmidt <benh@...nel.crashing.org>, Paul Mackerras <paulus@...ba.org>, Michael Ellerman <mpe@...erman.id.au>, Richard Fontana <rfontana@...hat.com>, Kate Stewart <kstewart@...uxfoundation.org>, Allison Randal <allison@...utok.net>, Thomas Gleixner <tglx@...utronix.de>, linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org, kernel@...o.com, trivial@...nel.org Subject: Re:Re: [PATCH v2] powerpc/fsl-85xx: fix compile error 发件人:Christophe Leroy <christophe.leroy@....fr> 发送日期:2020-03-14 01:45:11 收件人:WANG Wenhu <wenhu.wang@...o.com>,Benjamin Herrenschmidt <benh@...nel.crashing.org>,Paul Mackerras <paulus@...ba.org>,Michael Ellerman <mpe@...erman.id.au>,Richard Fontana <rfontana@...hat.com>,Kate Stewart <kstewart@...uxfoundation.org>,Allison Randal <allison@...utok.net>,Thomas Gleixner <tglx@...utronix.de>,linuxppc-dev@...ts.ozlabs.org,linux-kernel@...r.kernel.org 抄送人:kernel@...o.com,trivial@...nel.org 主题:Re: [PATCH v2] powerpc/fsl-85xx: fix compile error> > >Le 13/03/2020 à 18:19, WANG Wenhu a écrit : >> Include "linux/of_address.h" to fix the compile error for >> mpc85xx_l2ctlr_of_probe() when compiling fsl_85xx_cache_sram.c. >> >> CC arch/powerpc/sysdev/fsl_85xx_l2ctlr.o >> arch/powerpc/sysdev/fsl_85xx_l2ctlr.c: In function ‘mpc85xx_l2ctlr_of_probe’: >> arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:90:11: error: implicit declaration of function ‘of_iomap’; did you mean ‘pci_iomap’? [-Werror=implicit-function-declaration] >> l2ctlr = of_iomap(dev->dev.of_node, 0); >> ^~~~~~~~ >> pci_iomap >> arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:90:9: error: assignment makes pointer from integer without a cast [-Werror=int-conversion] >> l2ctlr = of_iomap(dev->dev.of_node, 0); >> ^ >> cc1: all warnings being treated as errors >> scripts/Makefile.build:267: recipe for target 'arch/powerpc/sysdev/fsl_85xx_l2ctlr.o' failed >> make[2]: *** [arch/powerpc/sysdev/fsl_85xx_l2ctlr.o] Error 1 >> >> Fixes: commit 6db92cc9d07d ("powerpc/85xx: add cache-sram support") > >Shouldn't you Cc stable as well ? Pretty sure if it makes a difference(that I did not recognize). Does the inconsistency of Cc lead to a failure on classification or something else which may confuse you? > >> Signed-off-by: WANG Wenhu <wenhu.wang@...o.com> >> --- > >What's the difference between v1 and v2 ? The label field modification: "Fixed" -> "Fixes", which now is identified successfully. Really sorry for the fault on v1. > >Christophe
Powered by blists - more mailing lists