linux-kernel - Re: [PATCH] perf tools: give synthetic mmap events an inode generation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200313184605.GB9917@kernel.org>
Date:   Fri, 13 Mar 2020 15:46:05 -0300
From:   Arnaldo Carvalho de Melo <arnaldo.melo@...il.com>
To:     Jiri Olsa <jolsa@...hat.com>
Cc:     Ian Rogers <irogers@...gle.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Namhyung Kim <namhyung@...nel.org>,
        linux-kernel@...r.kernel.org, clang-built-linux@...glegroups.com,
        Stephane Eranian <eranian@...gle.com>
Subject: Re: [PATCH] perf tools: give synthetic mmap events an inode
 generation

Em Fri, Mar 13, 2020 at 10:36:39AM +0100, Jiri Olsa escreveu:
> On Thu, Mar 12, 2020 at 10:31:29PM -0700, Ian Rogers wrote:
> 
> SNIP
> 
> > 
> > SUMMARY: MemorySanitizer: use-of-uninitialized-value tools/perf/util/dsos.c:23:6 in __dso_id__cmp
> > Signed-off-by: Ian Rogers <irogers@...gle.com>
> > ---
> >  tools/perf/util/synthetic-events.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/tools/perf/util/synthetic-events.c b/tools/perf/util/synthetic-events.c
> > index dd3e6f43fb86..5fddb64ec8c7 100644
> > --- a/tools/perf/util/synthetic-events.c
> > +++ b/tools/perf/util/synthetic-events.c
> > @@ -345,6 +345,7 @@ int perf_event__synthesize_mmap_events(struct perf_tool *tool,
> >  			continue;
> >  
> >  		event->mmap2.ino = (u64)ino;
> > +                event->mmap2.ino_generation = 0;
> 
> please use tabs for indent, other than that

I fixed that.
 
> Acked-by: iri Olsa <jolsa@...nel.org>

Thanks, applied.

- Arnaldo
 
> thanks,
> jirka
> 
> >  
> >  		/*
> >  		 * Just like the kernel, see __perf_event_mmap in kernel/perf_event.c
> > -- 
> > 2.25.1.481.gfbce0eb801-goog
> > 
> 

-- 

- Arnaldo