linux-kernel - Re: [PATCH 0/1] coredump: Fix null pointer dereference when kernel.core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fa636317af3a38badff322ca11e437701154b1be.camel@bonedaddy.net>
Date:   Sat, 14 Mar 2020 08:28:10 +0800
From:   Paul Wise <pabs3@...edaddy.net>
To:     Matthew Ruffell <matthew.ruffell@...onical.com>,
        viro@...iv.linux.org.uk, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     Neil Horman <nhorman@...driver.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Jakub Wilk <jwilk@...lk.net>
Subject: Re: [PATCH 0/1] coredump: Fix null pointer dereference when
 kernel.core_pattern is "|"

On Tue, 2020-03-10 at 11:34 +1300, Matthew Ruffell wrote:

> Can I please get some feedback on this patch? Would be good to clear
> up the null pointer dereference.

I had a thought about it, instead of using strlen, what about checking
that the first item in the array is NUL or not? In the normal case this
should be faster than strlen.

-- 
bye,
pabs

https://bonedaddy.net/pabs3/

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)