linux-kernel - [PATCH] fs/seq_file: Fix a string literal in seq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <325648be-032b-8b50-f4eb-a2cebce7a475@web.de>
Date:   Sat, 14 Mar 2020 14:32:44 +0100
From:   Markus Elfring <Markus.Elfring@....de>
To:     linux-fsdevel@...r.kernel.org,
        Alexander Viro <viro@...iv.linux.org.uk>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        Vasily Averin <vvs@...tuozzo.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org,
        Davidlohr Bueso <dave@...olabs.net>,
        Ingo Molnar <mingo@...hat.com>,
        Manfred Spraul <manfred@...orfullife.com>,
        Neil Brown <neilb@...e.com>,
        Peter Oberparleiter <oberpar@...ux.ibm.com>,
        Qian Cai <cai@....pw>, Steven Rostedt <rostedt@...dmis.org>,
        Waiman Long <longman@...hat.com>
Subject: [PATCH] fs/seq_file: Fix a string literal in seq_read()

From: Markus Elfring <elfring@...rs.sourceforge.net>
Date: Sat, 14 Mar 2020 14:14:19 +0100

* Improve a message a bit.

* The script “checkpatch.pl” pointed information out like the following.

  WARNING: quoted string split across lines

  Thus fix the affected source code place.

Fixes: defeadd3551c5565fbc76c97d6e99378b8acb1bf ("seq_read-info-message-about-buggy-next-functions-fix")
Fixes: c828e17c5312095fc25bbe78b16e97e99af72b9a ("fs/seq_file.c: seq_read(): add info message about buggy .next functions")
Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
---
 fs/seq_file.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/fs/seq_file.c b/fs/seq_file.c
index d2a3dc5b9f3d..85cee24d36e8 100644
--- a/fs/seq_file.c
+++ b/fs/seq_file.c
@@ -257,9 +257,8 @@ ssize_t seq_read(struct file *file, char __user *buf, size_t size, loff_t *ppos)

 		p = m->op->next(m, p, &m->index);
 		if (pos == m->index) {
-			pr_info_ratelimited("buggy seq_file .next function %ps "
-				"did not updated position index\n",
-				m->op->next);
+			pr_info_ratelimited("buggy seq_file .next function %ps did not update position index\n",
+					    m->op->next);
 			m->index++;
 		}
 		if (!p || IS_ERR(p)) {
--
2.25.1