linux-kernel - Re: [PATCH v2] iio:ad7797: Use correct attribute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200315091738.71f9dddf@archlinux>
Date:   Sun, 15 Mar 2020 09:17:38 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     YueHaibing <yuehaibing@...wei.com>
Cc:     <lars@...afoo.de>, <Michael.Hennerich@...log.com>,
        <stefan.popa@...log.com>, <knaack.h@....de>, <pmeerw@...erw.net>,
        <linux-iio@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] iio:ad7797: Use correct attribute_group

On Tue, 10 Mar 2020 22:16:54 +0800
YueHaibing <yuehaibing@...wei.com> wrote:

> It should use ad7797_attribute_group in ad7797_info,
> according to commit ("iio:ad7793: Add support for the ad7796 and ad7797").
> 
> Scale is fixed for the ad7796 and not programmable, hence
> should not have the scale_available attribute.
> 
> Fixes: fd1a8b912841 ("iio:ad7793: Add support for the ad7796 and ad7797")
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> Reviewed-by: Lars-Peter Clausen <lars@...afoo.de>
Thanks,

I've queued this up.  Won't push out just yet as I'm waiting for
Greg to pick up a pull request after which I'd like to fast forward
the fixes branch.

Thanks,

Jonathan

> ---
> v2: renew log as Lars-Peter's comment
> 
>  drivers/iio/adc/ad7793.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/adc/ad7793.c b/drivers/iio/adc/ad7793.c
> index b747db9..e5691e3 100644
> --- a/drivers/iio/adc/ad7793.c
> +++ b/drivers/iio/adc/ad7793.c
> @@ -542,7 +542,7 @@ static const struct iio_info ad7797_info = {
>  	.read_raw = &ad7793_read_raw,
>  	.write_raw = &ad7793_write_raw,
>  	.write_raw_get_fmt = &ad7793_write_raw_get_fmt,
> -	.attrs = &ad7793_attribute_group,
> +	.attrs = &ad7797_attribute_group,
>  	.validate_trigger = ad_sd_validate_trigger,
>  };
>