linux-kernel - Re: [PATCH] x86/acpi: make "asmlinkage" part first thing in the function definition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1684981.ixsy79CQbx@kreacher>
Date:   Sat, 14 Mar 2020 10:33:31 +0100
From:   "Rafael J. Wysocki" <rjw@...ysocki.net>
To:     Alexey Dobriyan <adobriyan@...il.com>
Cc:     lenb@...nel.org, tglx@...utronix.de, mingo@...hat.com,
        bp@...en8.de, hpa@...or.com, luto@...nel.org, x86@...nel.org,
        linux-kernel@...r.kernel.org, linux-acpi@...r.kernel.org
Subject: Re: [PATCH] x86/acpi: make "asmlinkage" part first thing in the function definition

On Tuesday, March 3, 2020 9:41:44 PM CET Alexey Dobriyan wrote:
> g++ insists that function declaration must start with extern "C"
> (which asmlinkage expands to).
> 
> gcc doesn't care.
> 
> Signed-off-by: Alexey Dobriyan <adobriyan@...il.com>
> ---
> 
>  arch/x86/kernel/acpi/sleep.c |    2 +-
>  arch/x86/kernel/acpi/sleep.h |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> --- a/arch/x86/kernel/acpi/sleep.c
> +++ b/arch/x86/kernel/acpi/sleep.c
> @@ -43,7 +43,7 @@ unsigned long acpi_get_wakeup_address(void)
>   *
>   * Wrapper around acpi_enter_sleep_state() to be called by assmebly.
>   */
> -acpi_status asmlinkage __visible x86_acpi_enter_sleep_state(u8 state)
> +asmlinkage acpi_status __visible x86_acpi_enter_sleep_state(u8 state)
>  {
>  	return acpi_enter_sleep_state(state);
>  }
> --- a/arch/x86/kernel/acpi/sleep.h
> +++ b/arch/x86/kernel/acpi/sleep.h
> @@ -19,4 +19,4 @@ extern void do_suspend_lowlevel(void);
>  
>  extern int x86_acpi_suspend_lowlevel(void);
>  
> -acpi_status asmlinkage x86_acpi_enter_sleep_state(u8 state);
> +asmlinkage acpi_status x86_acpi_enter_sleep_state(u8 state);
> 

Applied as 5.7 material, thanks!