linux-kernel - [PATCH net 0/3] ethtool: fail with error if request has unknown flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 15 Mar 2020 18:17:38 +0100 (CET)
From:   Michal Kubecek <mkubecek@...e.cz>
To:     David Miller <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org
Cc:     Johannes Berg <johannes@...solutions.net>,
        linux-kernel@...r.kernel.org
Subject: [PATCH net 0/3] ethtool: fail with error if request has unknown flags

Jakub Kicinski pointed out that if unrecognized flags are set in netlink
header request, kernel shoud fail with an error rather than silently
ignore them so that we have more freedom in future flags semantics.

To help userspace with handling such errors, inform the client which
flags are supported by kernel. For that purpose, we need to allow
passing cookies as part of extack also in case of error (they can be
only passed on success now).

Michal Kubecek (3):
  netlink: allow extack cookie also for error messages
  netlink: add nl_set_extack_cookie_u32()
  ethtool: reject unrecognized request flags

 include/linux/netlink.h  |  9 +++++++++
 net/ethtool/netlink.c    | 16 +++++++++++----
 net/netlink/af_netlink.c | 43 ++++++++++++++++------------------------
 3 files changed, 38 insertions(+), 30 deletions(-)

-- 
2.25.1