linux-kernel - Re: [Outreachy kernel] [PATCH] Staging: wilc1000: cfg80211: Use kmemdup instead of kmalloc and memcpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200315222938.23a9faec@elisabeth>
Date:   Sun, 15 Mar 2020 22:29:38 +0100
From:   Stefano Brivio <sbrivio@...hat.com>
To:     Shreeya Patel <shreeya.patel23498@...il.com>
Cc:     adham.abozaeid@...rochip.com, ajay.kathat@...rochip.com,
        linux-wireless@...r.kernel.org, gregkh@...uxfoundation.org,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
        outreachy-kernel@...glegroups.com, daniel.baluta@...il.com,
        nramas@...ux.microsoft.com, hverkuil@...all.nl
Subject: Re: [Outreachy kernel] [PATCH] Staging: wilc1000: cfg80211: Use
 kmemdup instead of kmalloc and memcpy

On Fri, 13 Mar 2020 16:54:51 +0530
Shreeya Patel <shreeya.patel23498@...il.com> wrote:

> Replace calls to kmalloc followed by a memcpy with a direct call to
> kmemdup.
> 
> The Coccinelle semantic patch used to make this change is as follows:
> @@
> expression from,to,size,flag;
> statement S;
> @@
> 
> -  to = \(kmalloc\|kzalloc\)(size,flag);
> +  to = kmemdup(from,size,flag);
>    if (to==NULL || ...) S
> -  memcpy(to, from, size);
> 
> Signed-off-by: Shreeya Patel <shreeya.patel23498@...il.com>

Reviewed-by: Stefano Brivio <sbrivio@...hat.com>

-- 
Stefano