linux-kernel - Re: [PATCH RFC 3/3] speakup: misc: Use dynamic minor numbers for speakup devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200314222128.mo4q3m72qoy76ayx@function>
Date:   Sat, 14 Mar 2020 23:21:28 +0100
From:   Samuel Thibault <samuel.thibault@...-lyon.org>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     Zhenzhong Duan <zhenzhong.duan@...il.com>,
        linux-kernel@...r.kernel.org, jdike@...toit.com, richard@....at,
        anton.ivanov@...bridgegreys.com, miguel.ojeda.sandonis@...il.com,
        willy@...roxy.com, ksenija.stanojevic@...il.com, arnd@...db.de,
        mpm@...enic.com, herbert@...dor.apana.org.au,
        jonathan@...zard.org.uk, benh@...nel.crashing.org,
        davem@...emloft.net, b.zolnierkie@...sung.com, rjw@...ysocki.net,
        pavel@....cz, len.brown@...el.com,
        William Hubbs <w.d.hubbs@...il.com>,
        Chris Brannon <chris@...-brannons.com>,
        Kirk Reiser <kirk@...sers.ca>
Subject: Re: [PATCH RFC 3/3] speakup: misc: Use dynamic minor numbers for
 speakup devices

Hello,

Greg KH, le lun. 09 mars 2020 08:15:06 +0100, a ecrit:
> On Mon, Mar 09, 2020 at 10:17:47AM +0800, Zhenzhong Duan wrote:
> > Arnd notes in the link:
> >    | To clarify: the only numbers that I think should be changed to dynamic
> >    | allocation are for drivers/staging/speakup. While this is a fairly old
> >    | subsystem, I would expect that it being staging means we can be a
> >    | little more progressive with the changes.
> > 
> > This releases misc device minor numbers 25-27 for dynamic usage.
> > 
> > Link: https://lore.kernel.org/lkml/20200120221323.GJ15860@mit.edu/t/
> > Suggested-by: Arnd Bergmann <arnd@...db.de>
> > Signed-off-by: Zhenzhong Duan <zhenzhong.duan@...il.com>

Acked-by: Samuel Thibault <samuel.thibault@...-lyon.org>

> > Cc: William Hubbs <w.d.hubbs@...il.com>
> > Cc: Chris Brannon <chris@...-brannons.com>
> > Cc: Kirk Reiser <kirk@...sers.ca>
> > Cc: Samuel Thibault <samuel.thibault@...-lyon.org>
> > Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> > ---
> >  drivers/staging/speakup/devsynth.c     | 10 +++-------
> >  drivers/staging/speakup/speakup_soft.c | 14 +++++++-------
> >  2 files changed, 10 insertions(+), 14 deletions(-)
> 
> speakup, while being in staging, has been around for a very long time,
> so we might break things if we change their minor numbers.
> 
> I'd need an ACK from the speakup maintainers/developers before I can
> take this as I don't have any way to verify what their systems look
> like.

I believe it will be fine to use dynamic minor numbers, since the /dev
entries are autocreated nowadays, and the espeakup and speechd-up don't
use hardcoded minor values.

Thanks for making sure,
Samuel