linux-kernel - Re: [PATCH v4 2/3] perf vendor events amd: add Zen2 events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <34be3999-34ef-871f-0950-089a00e5b1dd@amd.com>
Date:   Mon, 16 Mar 2020 16:51:52 -0500
From:   Kim Phillips <kim.phillips@....com>
To:     Vijay Thakkar <vijaythakkar@...com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...hat.com>,
        Namhyung Kim <namhyung@...nel.org>,
        Martin Liška <mliska@...e.cz>,
        Jon Grimm <jon.grimm@....com>, linux-kernel@...r.kernel.org,
        linux-perf-users@...r.kernel.org
Subject: Re: [PATCH v4 2/3] perf vendor events amd: add Zen2 events

On 3/13/20 11:44 PM, Vijay Thakkar wrote:
> Signed-off-by: Vijay Thakkar <vijaythakkar@...com>

This email address differs from patch 1/3's S-o-b:

Signed-off-by: thakkarv <thakkarv@...ech.edu>

Choose one, and please spell your whole name out - Vijay Thakkar.

> +++ b/tools/perf/pmu-events/arch/x86/amdzen2/branch.json
> @@ -0,0 +1,52 @@
> +[
> +  {
> +    "EventName": "bp_l1_btb_correct",
> +    "EventCode": "0x8a",
> +    "BriefDescription": "[L1 Branch Prediction Overrides Existing Prediction (speculative)."

Remove the leading '[' in the BriefDescription string.

Other than the above two nit picks:

Acked-by: Kim Phillips <kim.phillips@....com>

Thanks,

Kim