linux-kernel - Re: [PATCH v5 2/2] mm/sparse.c: allocate memmap preferring the given node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200316221651.nkif7tdkks5cmlnm@master>
Date:   Mon, 16 Mar 2020 22:16:51 +0000
From:   Wei Yang <richard.weiyang@...il.com>
To:     Baoquan He <bhe@...hat.com>
Cc:     linux-kernel@...r.kernel.org, linux-mm@...ck.org, mhocko@...e.com,
        akpm@...ux-foundation.org, david@...hat.com, willy@...radead.org,
        richard.weiyang@...il.com, vbabka@...e.cz
Subject: Re: [PATCH v5 2/2] mm/sparse.c: allocate memmap preferring the given
 node

On Mon, Mar 16, 2020 at 08:56:25PM +0800, Baoquan He wrote:
>When allocating memmap for hot added memory with the classic sparse, the
>specified 'nid' is ignored in populate_section_memmap().
>
>While in allocating memmap for the classic sparse during boot, the node
>given by 'nid' is preferred. And VMEMMAP prefers the node of 'nid' in
>both boot stage and memory hot adding. So seems no reason to not respect
>the node of 'nid' for the classic sparse when hot adding memory.
>
>Use kvmalloc_node instead to use the passed in 'nid'.
>
>Signed-off-by: Baoquan He <bhe@...hat.com>
>Acked-by: Michal Hocko <mhocko@...e.com>
>Reviewed-by: Matthew Wilcox (Oracle) <willy@...radead.org>

Reviewed-by: Wei Yang <richard.weiyang@...il.com>


-- 
Wei Yang
Help you, Help me