linux-kernel - Re: [PATCH V3 2/7] firmware: imx: add COMPILE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200316033752.GF17221@dragon>
Date:   Mon, 16 Mar 2020 11:37:53 +0800
From:   Shawn Guo <shawnguo@...nel.org>
To:     Anson Huang <Anson.Huang@....com>
Cc:     s.hauer@...gutronix.de, kernel@...gutronix.de, festevam@...il.com,
        dmitry.torokhov@...il.com, a.zummo@...ertech.it,
        alexandre.belloni@...tlin.com, rui.zhang@...el.com,
        daniel.lezcano@...aro.org, amit.kucheria@...durent.com,
        wim@...ux-watchdog.org, linux@...ck-us.net, daniel.baluta@....com,
        gregkh@...uxfoundation.org, linux@...pel-privat.de,
        tglx@...utronix.de, m.felsch@...gutronix.de,
        andriy.shevchenko@...ux.intel.com, arnd@...db.de,
        ronald@...ovation.ch, krzk@...nel.org, robh@...nel.org,
        leonard.crestez@....com, aisheng.dong@....com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-input@...r.kernel.org, linux-rtc@...r.kernel.org,
        linux-pm@...r.kernel.org, linux-watchdog@...r.kernel.org,
        Linux-imx@....com
Subject: Re: [PATCH V3 2/7] firmware: imx: add COMPILE_TEST support

On Mon, Mar 09, 2020 at 08:38:15AM +0800, Anson Huang wrote:
> Add COMPILE_TEST support to i.MX SCU drivers for better compile
> testing coverage.
> 
> Signed-off-by: Anson Huang <Anson.Huang@....com>
> ---
> No change.
> ---
>  drivers/firmware/imx/Kconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/firmware/imx/Kconfig b/drivers/firmware/imx/Kconfig
> index 1d2e5b8..116707a 100644
> --- a/drivers/firmware/imx/Kconfig
> +++ b/drivers/firmware/imx/Kconfig
> @@ -12,7 +12,7 @@ config IMX_DSP
>  
>  config IMX_SCU
>  	bool "IMX SCU Protocol driver"
> -	depends on IMX_MBOX
> +	depends on IMX_MBOX || COMPILE_TEST
>  	help
>  	  The System Controller Firmware (SCFW) is a low-level system function
>  	  which runs on a dedicated Cortex-M core to provide power, clock, and
> @@ -24,6 +24,6 @@ config IMX_SCU
>  
>  config IMX_SCU_PD
>  	bool "IMX SCU Power Domain driver"
> -	depends on IMX_SCU
> +	depends on IMX_SCU || COMPILE_TEST

Just reminded by Peng, as we go without adding stubs for !IMX_SCU, any
driver depending on IMX_SCU shouldn't have COMPILE_TEST.  I fixed it up
by dropping COMPILE_TEST from IMX_SCU_PD.

Shawn

>  	help
>  	  The System Controller Firmware (SCFW) based power domain driver.
> -- 
> 2.7.4
>