linux-kernel - [PATCH v2,RESEND] scsi/ipr: fix wrong __VA_ARGS_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Mon, 16 Mar 2020 11:46:29 +0800
From:   Zheng Wei <wei.zheng@...o.com>
To:     Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will@...nel.org>, Brian King <brking@...ibm.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Kate Stewart <kstewart@...uxfoundation.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Hanjun Guo <guohanjun@...wei.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Yunfeng Ye <yeyunfeng@...wei.com>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-scsi@...r.kernel.org
Cc:     kernel@...o.com, wenhu.wang@...o.com,
        Zheng Wei <wei.zheng@...o.com>
Subject: [PATCH v2,RESEND] scsi/ipr: fix wrong __VA_ARGS__ usage

ipr_hcam_err uses __VA_ARGS__ without "##" prefix, 
it causes a build error when there is no variable arguments.

Signed-off-by: Zheng Wei <wei.zheng@...o.com>
---

changelog
v1 -> v2
 - resend for the failure of delivery to some recipients.

 drivers/scsi/ipr.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/scsi/ipr.h b/drivers/scsi/ipr.h
index b97aa9ac2ffe..de3401972354 100644
--- a/drivers/scsi/ipr.h
+++ b/drivers/scsi/ipr.h
@@ -1813,14 +1813,14 @@ struct ipr_ucode_image_header {
 					hostrcb->hcam.u.error64.fd_res_path, \
 					hostrcb->rp_buffer,		\
 					sizeof(hostrcb->rp_buffer)),	\
-				__VA_ARGS__);				\
+				##__VA_ARGS__);				\
 		} else {						\
 			ipr_ra_err((hostrcb)->ioa_cfg,			\
 				(hostrcb)->hcam.u.error.fd_res_addr,	\
-				fmt, __VA_ARGS__);			\
+				fmt, ##__VA_ARGS__);			\
 		}							\
 	} else {							\
-		dev_err(&(hostrcb)->ioa_cfg->pdev->dev, fmt, __VA_ARGS__); \
+		dev_err(&(hostrcb)->ioa_cfg->pdev->dev, fmt, ##__VA_ARGS__); \
 	}								\
 }
 
-- 
2.17.1