linux-kernel - Re: [PATCH v3] powerpc/fsl-85xx: fix compile error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AJUA5gAVCMaMlIkPsaTC0KqL.3.1584357605616.Hmail.wenhu.wang@vivo.com>
Date:   Mon, 16 Mar 2020 19:20:05 +0800 (GMT+08:00)
From:   王文虎 <wenhu.wang@...o.com>
To:     Michael Ellerman <mpe@...erman.id.au>
Cc:     Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Paul Mackerras <paulus@...ba.org>,
        Allison Randal <allison@...utok.net>,
        Richard Fontana <rfontana@...hat.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
        trivial@...nel.org, kernel@...o.com,
        stable <stable@...r.kernel.org>
Subject: Re: [PATCH v3] powerpc/fsl-85xx: fix compile error

From: Michael Ellerman <mpe@...erman.id.au>
 Date: 2020-03-16 17:41:12
To:WANG Wenhu <wenhu.wang@...o.com>,Benjamin Herrenschmidt <benh@...nel.crashing.org>,Paul Mackerras <paulus@...ba.org>,WANG Wenhu <wenhu.wang@...o.com>,Allison Randal <allison@...utok.net>,Richard Fontana <rfontana@...hat.com>,Greg Kroah-Hartman <gregkh@...uxfoundation.org>,Thomas Gleixner <tglx@...utronix.de>,linuxppc-dev@...ts.ozlabs.org,linux-kernel@...r.kernel.org
 cc: trivial@...nel.org,kernel@...o.com,stable <stable@...r.kernel.org>
Subject: Re: [PATCH v3] powerpc/fsl-85xx: fix compile error>WANG Wenhu <wenhu.wang@...o.com> writes:
>> Include "linux/of_address.h" to fix the compile error for
>> mpc85xx_l2ctlr_of_probe() when compiling fsl_85xx_cache_sram.c.
>>
>>   CC      arch/powerpc/sysdev/fsl_85xx_l2ctlr.o
>> arch/powerpc/sysdev/fsl_85xx_l2ctlr.c: In function ‘mpc85xx_l2ctlr_of_probe’:
>> arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:90:11: error: implicit declaration of function ‘of_iomap’; did you mean ‘pci_iomap’? [-Werror=implicit-function-declaration]
>>   l2ctlr = of_iomap(dev->dev.of_node, 0);
>>            ^~~~~~~~
>>            pci_iomap
>> arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:90:9: error: assignment makes pointer from integer without a cast [-Werror=int-conversion]
>>   l2ctlr = of_iomap(dev->dev.of_node, 0);
>>          ^
>> cc1: all warnings being treated as errors
>> scripts/Makefile.build:267: recipe for target 'arch/powerpc/sysdev/fsl_85xx_l2ctlr.o' failed
>> make[2]: *** [arch/powerpc/sysdev/fsl_85xx_l2ctlr.o] Error 1
>>
>> Fixes: commit 6db92cc9d07d ("powerpc/85xx: add cache-sram support")
>
>The syntax is:
>
>Fixes: 6db92cc9d07d ("powerpc/85xx: add cache-sram support")
>
>> Cc: stable <stable@...r.kernel.org>
>
>The commit above went into v2.6.37.
>
>So no one has noticed this bug since then, how? Or did something else
>change to expose the problem?

Actually a hard question to answer cause it also left me scratching for long.
However, I can not find right or definite answer.

A convincing explanation is the driver has not been in use since v2.6.37,
but somehow, we are to use it recently.
Anyway, it's better for me as well as no harm to anyone to fix it even though.

Thanks, Wenhu
>
>cheers