linux-kernel - Re: [PATCH] clk: socfpga: stratix10: use new parent data scheme

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <158437447025.164562.7882527369683773048@swboyd.mtv.corp.google.com>
Date:   Mon, 16 Mar 2020 09:01:10 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Dinh Nguyen <dinguyen@...nel.org>
Cc:     mturquette@...libre.com, linux-clk@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clk: socfpga: stratix10: use new parent data scheme

Quoting Dinh Nguyen (2020-03-09 22:55:27)
> 
> 
> On 3/9/20 5:27 PM, Stephen Boyd wrote:
> > Quoting Dinh Nguyen (2020-02-28 12:36:11)
> >> +
> >> +static const struct clk_parent_data mpu_free_mux[] = {
> >> +       { .name = "main_mpu_base_clk", },
> >> +       { .name = "peri_mpu_base_clk", },
> >> +       { .name = "osc1", },
> >> +       { .name = "cb-intosc-hs-div2-clk", },
> >> +       { .name = "f2s-free-clk", },
> >> +};
> > 
> > While this changes everything to use the new way it doesn't actually
> > migrate anything over to using direct pointers or the .fw_name field.
> > What's going on?
> > 
> 
> Sorry about that. I am using direct pointers to the new parent data here:
> 
> in drivers/clk/socfpga/clk-periph-s10.c
> 
> -       init.parent_names = parent_names;
> +       init.parent_names = NULL;
> +       init.parent_data = clks->parent_data;
> 
> The driver seems to work fine without having to add .fw_name.
> 

Yes, .fw_name would only be needed if the parent clks were external to
the clk controller. Furthermore if they are only clk_hw pointers then we
can use .parent_hws instead.