linux-kernel - Re: [PATCH 02/10] x86/resctrl: Remove max

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0069c11a-772c-23d8-a9f1-c8cb0e2a1c63@intel.com>
Date:   Mon, 16 Mar 2020 11:11:34 -0700
From:   Reinette Chatre <reinette.chatre@...el.com>
To:     James Morse <james.morse@....com>, x86@...nel.org,
        linux-kernel@...r.kernel.org
Cc:     Fenghua Yu <fenghua.yu@...el.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        "H . Peter Anvin" <hpa@...or.com>, Babu Moger <Babu.Moger@....com>
Subject: Re: [PATCH 02/10] x86/resctrl: Remove max_delay

Hi James,

On 2/14/2020 10:23 AM, James Morse wrote:
> max_delay is used by x86's rdt_get_mem_config() as a local variable.

get_mem_config() may be more appropriate since rdt_get_mem_config() does
not exist, __get_mem_config_intel() would be most accurate.

> Remove it, replacing it with a local variable.
> 
> Signed-off-by: James Morse <james.morse@....com>
> ---

Apart from the above ...

Reviewed-by: Reinette Chatre <reinette.chatre@...el.com>

Thank you

Reinette