lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <070d9148-8166-d2c5-63c0-5f6a0f56b730@intel.com>
Date:   Mon, 16 Mar 2020 11:13:42 -0700
From:   Reinette Chatre <reinette.chatre@...el.com>
To:     James Morse <james.morse@....com>, x86@...nel.org,
        linux-kernel@...r.kernel.org
Cc:     Fenghua Yu <fenghua.yu@...el.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        "H . Peter Anvin" <hpa@...or.com>, Babu Moger <Babu.Moger@....com>
Subject: Re: [PATCH 04/10] x86/resctrl: use container_of() in delayed_work
 handlers

Hi James,

On 2/14/2020 10:23 AM, James Morse wrote:
> mbm_handle_overflow() and cqm_handle_limbo() are both provided with
> the domain's work_struct when called, but use get_domain_from_cpu()
> to find the domain, along with the appropriate error handling.
> 
> container_of() saves some list walking and bitmap testing, use that
> instead.
> 
> Signed-off-by: James Morse <james.morse@....com>
> ---

Reviewed-by: Reinette Chatre <reinette.chatre@...el.com>

Thank you

Reinette

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ