linux-kernel - Re: [patch v3] EDAC: synopsys: Fix the wrong call of pinf->col parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 17 Mar 2020 14:38:23 +0100
From:   Borislav Petkov <bp@...en8.de>
To:     Sherry Sun <sherry.sun@....com>
Cc:     mchehab@...nel.org, tony.luck@...el.com, james.morse@....com,
        rrichter@...vell.com, michal.simek@...inx.com,
        manish.narani@...inx.com, linux-edac@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-imx@....com, frank.li@....com
Subject: Re: [patch v3] EDAC: synopsys: Fix the wrong call of pinf->col
 parameter

On Mon, Mar 16, 2020 at 09:34:39PM +0800, Sherry Sun wrote:
> Since ZynqMP platform call zynqmp_get_error_info() function to get ce/ue
> information. In this function, pinf->col parameter is not used, this
> parameter is only used by Zynq platforme in zynq_get_error_info(). So
> here pinf->col should not be called and printed for ZynqMP, need remove
> it.
> 
> In order to show which function called handle_error() explicitly, here
> use DDR_ECC_INTR_SUPPORT as check condition to distinguish Zynq and
> ZynqMP platform instead the current way.
> 
> Fixes: b500b4a029d57 ("EDAC, synopsys: Add ECC support for ZynqMP DDR controller")
> Signed-off-by: Sherry Sun <sherry.sun@....com>
> Reviewed-by: Manish Narani <manish.narani@...inx.com>
> ---
> Changes in V3:
> - Make the check condition in handle_error() more explicitly, use 
> quirks & DDR_ECC_INTR_SUPPORT instead !quirks, and exchange the context in
> if/else.
> 
> Changes in V2:
> - Separated this patch from the original patchset.
> 
> ---
>  drivers/edac/synopsys_edac.c | 22 +++++++++++-----------
>  1 file changed, 11 insertions(+), 11 deletions(-)

Applied, thanks.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette