linux-kernel - Re: [RFC][PATCH 05/16] objtool: Optimize find_symbol_by

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200317140829.GA20730@hirez.programming.kicks-ass.net>
Date:   Tue, 17 Mar 2020 15:08:29 +0100
From:   Peter Zijlstra <peterz@...radead.org>
To:     Miroslav Benes <mbenes@...e.cz>
Cc:     tglx@...utronix.de, jpoimboe@...hat.com,
        linux-kernel@...r.kernel.org, x86@...nel.org
Subject: Re: [RFC][PATCH 05/16] objtool: Optimize find_symbol_by_index()

On Tue, Mar 17, 2020 at 12:55:01PM +0100, Miroslav Benes wrote:
> > --- a/tools/objtool/elf.h
> > +++ b/tools/objtool/elf.h
> > @@ -27,7 +27,6 @@ struct section {
> >  	struct list_head list;
> >  	GElf_Shdr sh;
> >  	struct list_head symbol_list;
> > -	DECLARE_HASHTABLE(symbol_hash, 8);
> >  	struct list_head rela_list;
> >  	DECLARE_HASHTABLE(rela_hash, 16);
> >  	struct section *base, *rela;
> > @@ -71,7 +70,7 @@ struct elf {
> >  	int fd;
> >  	char *name;
> >  	struct list_head sections;
> > -	DECLARE_HASHTABLE(rela_hash, 16);
> > +	DECLARE_HASHTABLE(symbol_hash, 20);
> >  };
> 
> Not that it really matters, but what was rela_hash in struct elf for 
> before this?

Unused afaict.