linux-kernel - Re: [PATCH v2 2/7] perf jevents: Support test events folder

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 17 Mar 2020 16:25:32 +0000
From:   John Garry <john.garry@...wei.com>
To:     Jiri Olsa <jolsa@...hat.com>
CC:     <peterz@...radead.org>, <mingo@...hat.com>, <acme@...nel.org>,
        <mark.rutland@....com>, <alexander.shishkin@...ux.intel.com>,
        <namhyung@...nel.org>, <will@...nel.org>, <ak@...ux.intel.com>,
        <linuxarm@...wei.com>, <linux-kernel@...r.kernel.org>,
        <james.clark@....com>, <qiangqing.zhang@....com>
Subject: Re: [PATCH v2 2/7] perf jevents: Support test events folder

On 17/03/2020 16:20, Jiri Olsa wrote:
> On Tue, Mar 17, 2020 at 07:02:14PM +0800, John Garry wrote:
>> With the goal of supporting pmu-events test case, introduce support for a
>> test events folder.
>>
>> These test events can be used for testing generation of pmu-event tables
>> and alias creation for any arch.
>>
>> When running the pmu-events test case, these test events will be used
>> as the platform-agnostic events, so aliases can be created per-PMU and
>> validated against known expected values.
>>
>> To support the test events, add a "testcpu" entry in pmu_events_map[].
>> The pmu-events test will be able to lookup the events map for "testcpu",
>> to verify the generated tables against expected values.
>>
>> The resultant generated pmu-events.c will now look like the following:
> 
> can't compile this one:
> 
>    HOSTCC   pmu-events/jevents.o
> pmu-events/jevents.c: In function ‘main’:
> pmu-events/jevents.c:1195:3: error: ‘ret’ undeclared (first use in this function)
>   1195 |   ret = 1;
>        |   ^~~
> pmu-events/jevents.c:1195:3: note: each undeclared identifier is reported only once for each function it appears in
> pmu-events/jevents.c:1196:3: error: label ‘out_free_mapfile’ used but not defined
>   1196 |   goto out_free_mapfile;
>        |   ^~~~
> mv: cannot stat 'pmu-events/.jevents.o.tmp': No such file or directory
> make[3]: *** [/home/jolsa/kernel/linux-perf/tools/build/Makefile.build:97: pmu-events/jevents.o] Error 1
> make[2]: *** [Makefile.perf:619: pmu-events/jevents-in.o] Error 2
> make[1]: *** [Makefile.perf:225: sub-make] Error 2
> make: *** [Makefile:70: all] Error 2

Hi jirka,

What baseline are you using? I used v5.6-rc6. The patches are here:

https://github.com/hisilicon/kernel-dev/commits/private-topic-perf-5.6-pmu-events-test-upstream-v2

thanks,
John