lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 17 Mar 2020 11:33:26 -0500 From: Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com> To: alsa-devel@...a-project.org Cc: linux-kernel@...r.kernel.org, tiwai@...e.de, broonie@...nel.org, vkoul@...nel.org, gregkh@...uxfoundation.org, jank@...ence.com, srinivas.kandagatla@...aro.org, slawomir.blauciak@...el.com, Bard liao <yung-chuan.liao@...ux.intel.com>, Rander Wang <rander.wang@...ux.intel.com>, Ranjani Sridharan <ranjani.sridharan@...ux.intel.com>, Hui Wang <hui.wang@...onical.com>, Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>, Sanyog Kale <sanyog.r.kale@...el.com> Subject: [PATCH v2 14/17] soundwire: cadence: remove automatic command retries This is a good idea on paper, but it's not recommended at all when operating in multi-master mode. It's also not recommended when doing bank switches, since the retransmission would happen at the next SSP, and the command protocol is stuck in the mean time. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com> --- drivers/soundwire/cadence_master.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/soundwire/cadence_master.c b/drivers/soundwire/cadence_master.c index 420ad23c5530..c9fdd4deb4f5 100644 --- a/drivers/soundwire/cadence_master.c +++ b/drivers/soundwire/cadence_master.c @@ -1109,8 +1109,7 @@ int sdw_cdns_init(struct sdw_cdns *cdns) /* leave frame delay to hardware default of 0x1F */ - /* Set Max cmd retry to 15 */ - val |= CDNS_MCP_CONFIG_MCMD_RETRY; + /* leave command retry to hardware default of 0 */ cdns_writel(cdns, CDNS_MCP_CONFIG, val); -- 2.20.1
Powered by blists - more mailing lists