linux-kernel - Re: [RFC PATCH 1/7] pwm: rename the PWM_POLARITY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGgjyvE9+fHDKiua=BWBaTRGaChsOvnUnG6RGA9Q4V4uPuPEhQ@mail.gmail.com>
Date:   Tue, 17 Mar 2020 18:39:58 +0200
From:   Oleksandr Suvorov <oleksandr.suvorov@...adex.com>
To:     Claudiu.Beznea@...rochip.com
Cc:     devicetree@...r.kernel.org, linux-pwm@...r.kernel.org,
        Paul Barker <pbarker@...sulko.com>,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Marcel Ziswiler <marcel.ziswiler@...adex.com>,
        Igor Opaniuk <igor.opaniuk@...adex.com>,
        Philippe Schenker <philippe.schenker@...adex.com>,
        alexandre.belloni@...tlin.com, wens@...e.org,
        Fabio Estevam <festevam@...il.com>, f.fainelli@...il.com,
        heiko@...ech.de, khilman@...libre.com,
        Ludovic.Desroches@...rochip.com, mripard@...nel.org,
        NXP Linux Team <linux-imx@....com>,
        Nicolas.Ferre@...rochip.com, palmer@...belt.com,
        paul@...pouillou.net, paul.walmsley@...ive.com,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        rjui@...adcom.com, Sascha Hauer <s.hauer@...gutronix.de>,
        sbranden@...adcom.com, Shawn Guo <shawnguo@...nel.org>,
        Thierry Reding <thierry.reding@...il.com>,
        linux@...sktech.co.nz, bcm-kernel-feedback-list@...adcom.com,
        linux-amlogic@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-riscv@...ts.infradead.org, linux-rockchip@...ts.infradead.org
Subject: Re: [RFC PATCH 1/7] pwm: rename the PWM_POLARITY_INVERSED enum

On Tue, Mar 17, 2020 at 6:27 PM <Claudiu.Beznea@...rochip.com> wrote:
>
>
>
> On 17.03.2020 14:32, Oleksandr Suvorov wrote:
> > @@ -187,7 +187,7 @@ static ssize_t polarity_store(struct device *child,
> >         if (sysfs_streq(buf, "normal"))
> >                 polarity = PWM_POLARITY_NORMAL;
> >         else if (sysfs_streq(buf, "inversed"))
>
> You may also consider this string     ^

Thanks for the feedback, Claudiu.

I thought about it and decided not to change the ABI, as this change
can impact lots of user-land applications.
As a minimum, I can push this change as a separate patch to be able to
revert the change of ABI only.
What do you think?

> > -               polarity = PWM_POLARITY_INVERSED;
> > +               polarity = PWM_POLARITY_INVERTED;



-- 
Best regards
Oleksandr Suvorov

Toradex AG
Ebenaustrasse 10 | 6048 Horw | Switzerland | T: +41 41 500 48 00