linux-kernel - Re: [PATCH 1/2] PNP: constify driver name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 17 Mar 2020 18:46:24 +0100
From:   "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>
To:     Corentin Labbe <clabbe@...libre.com>
Cc:     a.zummo@...ertech.it, alexandre.belloni@...tlin.com,
        linux-kernel@...r.kernel.org, linux-rtc@...r.kernel.org,
        linux-acpi@...r.kernel.org
Subject: Re: [PATCH 1/2] PNP: constify driver name

On 3/6/2020 8:53 AM, Corentin Labbe wrote:
> struct pnp_driver has name set as char* instead of const char* like platform_driver, pci_driver, usb_driver, etc...
> Let's unify a bit by setting name as const char*.
> Furthermore, all users of this structures set name from already const
> data.
>
> Signed-off-by: Corentin Labbe <clabbe@...libre.com>
> ---
>   include/linux/pnp.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/pnp.h b/include/linux/pnp.h
> index 3b12fd28af78..b18dca67253d 100644
> --- a/include/linux/pnp.h
> +++ b/include/linux/pnp.h
> @@ -379,7 +379,7 @@ struct pnp_id {
>   };
>   
>   struct pnp_driver {
> -	char *name;
> +	const char *name;
>   	const struct pnp_device_id *id_table;
>   	unsigned int flags;
>   	int (*probe) (struct pnp_dev *dev, const struct pnp_device_id *dev_id);

Applied as 5.7 material along with the [2/2].

BTW, please CC PNP patches to linux-acpi in the future.