linux-kernel - Re: [PATCH 04/17] kernel: futex.c: get rid of a docs build warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200317191647.GC20713@hirez.programming.kicks-ass.net>
Date:   Tue, 17 Mar 2020 20:16:47 +0100
From:   Peter Zijlstra <peterz@...radead.org>
To:     Jonathan Corbet <corbet@....net>
Cc:     Mauro Carvalho Chehab <mchehab+huawei@...nel.org>,
        Linux Doc Mailing List <linux-doc@...r.kernel.org>,
        linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        Darren Hart <dvhart@...radead.org>
Subject: Re: [PATCH 04/17] kernel: futex.c: get rid of a docs build warning

On Tue, Mar 17, 2020 at 11:36:33AM -0600, Jonathan Corbet wrote:
> On Tue, 17 Mar 2020 17:58:05 +0100
> Peter Zijlstra <peterz@...radead.org> wrote:
> 
> > On Tue, Mar 17, 2020 at 03:54:13PM +0100, Mauro Carvalho Chehab wrote:
> > > Adjust whitespaces and blank lines in order to get rid of this:
> > > 
> > > 	./kernel/futex.c:491: WARNING: Definition list ends without a blank line; unexpected unindent.
> > > 
> > > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
> > > ---
> > >  kernel/futex.c | 3 ++-
> > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/kernel/futex.c b/kernel/futex.c
> > > index 67f004133061..dda6ddbc2e7d 100644
> > > --- a/kernel/futex.c
> > > +++ b/kernel/futex.c
> > > @@ -486,7 +486,8 @@ static u64 get_inode_sequence_number(struct inode *inode)
> > >   * The key words are stored in @key on success.
> > >   *
> > >   * For shared mappings (when @fshared), the key is:
> > > - *   ( inode->i_sequence, page->index, offset_within_page )
> > > + * ( inode->i_sequence, page->index, offset_within_page )
> > > + *  
> > 
> > WTH, that's less readable.
> 
> It won't render well in the build either; that should be a literal block.

it renders perfectly in an ASCII text editor, which is by far the most
important interface for all this.