linux-kernel - Re: [PATCH v3 1/5] drivers: provide devm_platform_get_and_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 17 Mar 2020 20:20:51 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Dejin Zheng <zhengdejin5@...il.com>
Cc:     rafael@...nel.org, hminas@...opsys.com, mathias.nyman@...el.com,
        bgolaszewski@...libre.com, arnd@...db.de,
        jeffrey.t.kirsher@...el.com, hdegoede@...hat.com,
        treding@...dia.com, tglx@...utronix.de, tomas.winkler@...el.com,
        suzuki.poulose@....com, sergei.shtylyov@...entembedded.com,
        geert@...ux-m68k.org, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/5] drivers: provide
 devm_platform_get_and_ioremap_resource()

On Sun, Mar 15, 2020 at 10:05:21PM +0800, Dejin Zheng wrote:
> Since commit "drivers: provide devm_platform_ioremap_resource()",
> it was wrap platform_get_resource() and devm_ioremap_resource() as
> single helper devm_platform_ioremap_resource(). but now, many drivers
> still used platform_get_resource() and devm_ioremap_resource()
> together in the kernel tree. The reason can not be replaced is they
> still need use the resource variables obtained by platform_get_resource().
> so provide this helper.
> 
> Suggested-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> Suggested-by: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
> Signed-off-by: Dejin Zheng <zhengdejin5@...il.com>
> ---
> v2 -> v3:
> 	- rename the function to
> 	  devm_platform_get_and_ioremap_resource() by Sergei's suggestion.
> 	- make the last parameter res as optional by Geert's suggestion.
> 
> v1 -> v2:
> 	- No change.
> 
>  drivers/base/platform.c         | 22 ++++++++++++++++++++++
>  include/linux/platform_device.h |  3 +++
>  2 files changed, 25 insertions(+)
> 
> diff --git a/drivers/base/platform.c b/drivers/base/platform.c
> index 7fa654f1288b..9f6a78f79235 100644
> --- a/drivers/base/platform.c
> +++ b/drivers/base/platform.c
> @@ -62,6 +62,28 @@ struct resource *platform_get_resource(struct platform_device *dev,
>  EXPORT_SYMBOL_GPL(platform_get_resource);
>  
>  #ifdef CONFIG_HAS_IOMEM
> +/**
> + * devm_platform_get_and_ioremap_resource - call devm_ioremap_resource() for a
> + *					    platform device and get resource
> + *
> + * @pdev: platform device to use both for memory resource lookup as well as
> + *        resource management
> + * @index: resource index
> + * @res: get the resource
> + */
> +void __iomem *
> +devm_platform_get_and_ioremap_resource(struct platform_device *pdev,
> +				unsigned int index, struct resource **res)
> +{
> +	struct resource *r;
> +
> +	r = platform_get_resource(pdev, IORESOURCE_MEM, index);
> +	if (res)
> +		*res = r;

What happens if that call fails?  Shouldn't that be checked?

thanks,

greg k-h