linux-kernel - Re: [PATCH v2 1/1] firmware: tee_bnxt: remove unused variable assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 17 Mar 2020 14:32:20 -0500
From:   Tyler Hicks <tyhicks@...ux.microsoft.com>
To:     Rayagonda Kokatanur <rayagonda.kokatanur@...adcom.com>
Cc:     Rafał Miłecki <zajec5@...il.com>,
        linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org,
        BCM Kernel Feedback <bcm-kernel-feedback-list@...adcom.com>
Subject: Re: [PATCH v2 1/1] firmware: tee_bnxt: remove unused variable
 assignment

On 2020-03-17 15:20:37, Rayagonda Kokatanur wrote:
> Remove unused variable assignment.
> 
> Signed-off-by: Rayagonda Kokatanur <rayagonda.kokatanur@...adcom.com>

Reviewed-by: Tyler Hicks <tyhicks@...ux.microsoft.com>

Tyler

> ---
> Changes from v1:
> - Address code review comment from Sergei Shtylyov,
>   Correct the commit message.
> 
>  drivers/firmware/broadcom/tee_bnxt_fw.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/firmware/broadcom/tee_bnxt_fw.c b/drivers/firmware/broadcom/tee_bnxt_fw.c
> index ed10da5313e8..6fd62657e35f 100644
> --- a/drivers/firmware/broadcom/tee_bnxt_fw.c
> +++ b/drivers/firmware/broadcom/tee_bnxt_fw.c
> @@ -143,8 +143,6 @@ int tee_bnxt_copy_coredump(void *buf, u32 offset, u32 size)
>  	prepare_args(TA_CMD_BNXT_COPY_COREDUMP, &arg, param);
>  
>  	while (rbytes)  {
> -		nbytes = rbytes;
> -
>  		nbytes = min_t(u32, rbytes, param[0].u.memref.size);
>  
>  		/* Fill additional invoke cmd params */
> -- 
> 2.17.1
>