linux-kernel - Re: [PATCH] pinctrl: da9062: Fix include path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200317211020.4ozletmpvz67jytb@pengutronix.de>
Date:   Tue, 17 Mar 2020 22:10:20 +0100
From:   Marco Felsch <m.felsch@...gutronix.de>
To:     Valdis Klētnieks <valdis.kletnieks@...edu>
Cc:     Support Opensource <support.opensource@...semi.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pinctrl: da9062: Fix include path

Hi,

On 20-03-17 00:54, Valdis Klētnieks wrote:
> Found during a allmodconfig build on ARM on an RPi4:
> 
>   CC      drivers/pinctrl/pinctrl-da9062.o
> drivers/pinctrl/pinctrl-da9062.c:28:10: fatal error: ../gpio/gpiolib.h: No such file or directory
>  #include <../gpio/gpiolib.h>
>           ^~~~~~~~~~~~~~~~~~~
> compilation terminated.

this should be fixed already:

https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/drivers/pinctrl/pinctrl-da9062.c?id=2353810dac9ab72d3f835e3fb015c6819a0ef6c2

Regards,
  Marco

> 
> So... fix the errant include.
> 
> Signed-off-by: Valdis Kletnieks <valdis.kletnieks@...edu>
> Fixes: 56cc3af4e8c8e ("pinctrl: da9062: add driver support")
> 
> diff --git a/drivers/pinctrl/pinctrl-da9062.c b/drivers/pinctrl/pinctrl-da9062.c
> index f704ee0b2fd9..cfbe529e66c3 100644
> --- a/drivers/pinctrl/pinctrl-da9062.c
> +++ b/drivers/pinctrl/pinctrl-da9062.c
> @@ -25,7 +25,7 @@
>   * We need this get the gpio_desc from a <gpio_chip,offset> tuple to decide if
>   * the gpio is active low without a vendor specific dt-binding.
>   */
> -#include <../gpio/gpiolib.h>
> +#include <../drivers/gpio/gpiolib.h>
>  
>  #define DA9062_TYPE(offset)		(4 * (offset % 2))
>  #define DA9062_PIN_SHIFT(offset)	(4 * (offset % 2))
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |