linux-kernel - Re: [PATCH v8 4/8] crypto: caam

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0f5819d6-3485-1d2c-effd-4ae6d54f2498@nxp.com>
Date:   Tue, 17 Mar 2020 23:58:40 +0200
From:   Horia Geantă <horia.geanta@....com>
To:     Andrey Smirnov <andrew.smirnov@...il.com>,
        "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>
Cc:     Chris Healy <cphealy@...il.com>,
        Lucas Stach <l.stach@...gutronix.de>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Iuliana Prodan <iuliana.prodan@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>
Subject: Re: [PATCH v8 4/8] crypto: caam - simplify RNG implementation

On 3/16/2020 5:01 PM, Andrey Smirnov wrote:
> @@ -335,15 +225,18 @@ int caam_rng_init(struct device *ctrldev)
>  	if (!devres_open_group(ctrldev, caam_rng_init, GFP_KERNEL))
>  		return -ENOMEM;
>  
> -	ctx = devm_kzalloc(ctrldev, sizeof(*ctx), GFP_DMA | GFP_KERNEL);
> +	ctx = devm_kzalloc(ctrldev, sizeof(*ctx), GFP_KERNEL);
>  	if (!ctx)
>  		return -ENOMEM;
>  
> +	ctx->ctrldev = ctrldev;
> +
>  	ctx->rng.name    = "rng-caam";
>  	ctx->rng.init    = caam_init;
>  	ctx->rng.cleanup = caam_cleanup;
>  	ctx->rng.read    = caam_read;
>  	ctx->rng.priv    = (unsigned long)ctx;
> +	ctx->rng.quality = 1024;
>  
Nitpick: setting the quality should be moved to patch
"crypto: caam - limit single JD RNG output to maximum of 16 bytes"

Horia