linux-kernel - Re: [PATCH v2 rcu-dev 1/3] rcuperf: Add ability to increase object allocation size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <A6C6D60E-9E01-40FC-8396-9F2FF2803E2E@joelfernandes.org>
Date:   Tue, 17 Mar 2020 19:37:47 -0400
From:   joel@...lfernandes.org
To:     paulmck@...nel.org, "Paul E. McKenney" <paulmck@...nel.org>
CC:     LKML <linux-kernel@...r.kernel.org>,
        Davidlohr Bueso <dave@...olabs.net>,
        Josh Triplett <josh@...htriplett.org>,
        Lai Jiangshan <jiangshanlai@...il.com>,
        Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
        rcu <rcu@...r.kernel.org>, Steven Rostedt <rostedt@...dmis.org>,
        "Uladzislau Rezki (Sony)" <urezki@...il.com>
Subject: Re: [PATCH v2 rcu-dev 1/3] rcuperf: Add ability to increase object allocation size



On March 17, 2020 6:48:20 PM EDT, "Paul E. McKenney" <paulmck@...nel.org> wrote:
>On Tue, Mar 17, 2020 at 06:30:51PM -0400, Joel Fernandes wrote:
>> On Tue, Mar 17, 2020 at 5:45 PM Paul E. McKenney <paulmck@...nel.org>
>wrote:
>> >
>> > On Tue, Mar 17, 2020 at 02:08:22PM -0700, Paul E. McKenney wrote:
>> > > On Mon, Mar 16, 2020 at 12:32:26PM -0400, Joel Fernandes (Google)
>wrote:
>> > > > This allows us to increase memory pressure dynamically using a
>new
>> > > > rcuperf boot command line parameter called 'rcumult'.
>> > > >
>> > > > Signed-off-by: Joel Fernandes (Google) <joel@...lfernandes.org>
>> > >
>> > > Applied for testing and review, thank you!
>> >
>> > But testing did not go far:
>> >
>> > kernel/rcu/tree.c: In function ‘kfree_rcu_shrink_count’:
>> > kernel/rcu/tree.c:3120:16: warning: unused variable ‘flags’
>[-Wunused-variable]
>> >   unsigned long flags, count = 0;
>> 
>> I fixed the warning already but did not resend since it was just the
>> one unused variable warning. The patches are otherwise good to apply.
>> Sorry, and I can resend it soon if you are not reapplying right now.
>
>So remove "flags, " and all is well?

Yes, that's right. I dropped the lock but forgot to remove it.

>If so, I can just as easily fix that as take a new series.  But next
>time, please give a fella a warning.  ;-)

Will do, my bad. Thank you ;-)

- Joel

>
>							Thanx, Paul

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.