linux-kernel - Re: [PATCH v28 21/22] x86/vdso: Implement a vDSO for Intel SGX enclave call

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200317002706.GN24267@linux.intel.com>
Date:   Mon, 16 Mar 2020 17:27:06 -0700
From:   Sean Christopherson <sean.j.christopherson@...el.com>
To:     "Xing, Cedric" <cedric.xing@...el.com>
Cc:     Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>,
        Nathaniel McCallum <npmccallum@...hat.com>,
        linux-kernel@...r.kernel.org, x86@...nel.org,
        linux-sgx@...r.kernel.org, akpm@...ux-foundation.org,
        dave.hansen@...el.com, Neil Horman <nhorman@...hat.com>,
        "Huang, Haitao" <haitao.huang@...el.com>,
        andriy.shevchenko@...ux.intel.com, tglx@...utronix.de,
        "Svahn, Kai" <kai.svahn@...el.com>, bp@...en8.de,
        Josh Triplett <josh@...htriplett.org>, luto@...nel.org,
        kai.huang@...el.com, David Rientjes <rientjes@...gle.com>,
        Patrick Uiterwijk <puiterwijk@...hat.com>,
        Andy Lutomirski <luto@...capital.net>,
        Jethro Beekman <jethro@...tanix.com>,
        Connor Kuehl <ckuehl@...hat.com>,
        Harald Hoyer <harald@...hat.com>,
        Lily Sturmann <lsturman@...hat.com>
Subject: Re: [PATCH v28 21/22] x86/vdso: Implement a vDSO for Intel SGX
 enclave call

On Mon, Mar 16, 2020 at 05:18:14PM -0700, Xing, Cedric wrote:
> On 3/16/2020 4:59 PM, Sean Christopherson wrote:
> >On Mon, Mar 16, 2020 at 04:50:26PM -0700, Xing, Cedric wrote:
> >>On 3/16/2020 3:53 PM, Sean Christopherson wrote:
> >>>On Mon, Mar 16, 2020 at 11:38:24PM +0200, Jarkko Sakkinen wrote:
> >>>>>My suggestions explicitly maintained robustness, and in fact increased
> >>>>>it. If you think we've lost capability, please speak with specificity
> >>>>>rather than in vague generalities. Under my suggestions we can:
> >>>>>1. call the vDSO from C
> >>>>>2. pass context to the handler
> >>>>>3. have additional stack manipulation options in the handler
> >>>>>
> >>>>>The cost for this is a net 2 additional instructions. No existing
> >>>>>capability is lost.
> >>>>
> >>>>My vague generality in this case is just that the whole design
> >>>>approach so far has been to minimize the amount of wrapping to
> >>>>EENTER.
> >>>
> >>>Yes and no.   If we wanted to minimize the amount of wrapping around the
> >>>vDSO's ENCLU then we wouldn't have the exit handler shenanigans in the
> >>>first place.  The whole process has been about balancing the wants of each
> >>>use case against the overall quality of the API and code.
> >>>
> >>The design of this vDSO API was NOT to minimize wrapping, but to allow
> >>maximal flexibility. More specifically, we strove not to restrict how info
> >>was exchanged between the enclave and its host process. After all, calling
> >>convention is compiler specific - i.e. the enclave could be built by a
> >>different compiler (e.g. MSVC) that doesn't share the same list of CSRs as
> >>the host process. Therefore, the API has been implemented to pass through
> >>virtually all registers except those used by EENTER itself. Similarly, all
> >>registers are passed back from enclave to the caller (or the exit handler)
> >>except those used by EEXIT. %rbp is an exception because the vDSO API has to
> >>anchor the stack, using either %rsp or %rbp. We picked %rbp to allow the
> >>enclave to allocate space on the stack.
> >
> >And unless I'm missing something, using %rcx to pass @leaf would still
> >satisfy the above, correct?  Ditto for saving/restoring %rbx.
> >
> >I.e. a runtime that's designed to work with enclave's using a different
> >calling convention wouldn't be able to take advantage of being able to call
> >the vDSO from C, but neither would it take on any meaningful burden.
> >
> Not exactly.
> 
> If called directly from C code, the caller would expect CSRs to be
> preserved. Then who should preserve CSRs? It can't be the enclave because it
> may not follow the same calling convention. Moreover, the enclave may run
> into an exception, in which case it doesn't have the ability to restore
> CSRs. So it has to be done by the vDSO API. That means CSRs will be
> overwritten upon enclave exits, which violates the goal of "passing all
> registers back to the caller except those used by EEXIT".

IIUC, Nathaniel's use case is to run only enclaves that are compatible
with Linux's calling convention and to handle enclave exceptions in the
exit handler.

As I qualified above, there would certainly be runtimes and use cases that
would find no advantage in passing @leaf via %rcx and preserving %rbx.  I'm
well aware the Intel SDK falls into that bucket.  But again, the cost to
such runtimes is precisely one reg->reg MOV instruction.