linux-kernel - Re: [PATCH] cpufreq: imx6q-cpufreq: Improve the logic of -EPROBE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 17 Mar 2020 13:33:40 +0530
From:   Viresh Kumar <viresh.kumar@...aro.org>
To:     Anson Huang <Anson.Huang@....com>
Cc:     rjw@...ysocki.net, shawnguo@...nel.org, s.hauer@...gutronix.de,
        kernel@...gutronix.de, festevam@...il.com,
        linux-pm@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, Linux-imx@....com
Subject: Re: [PATCH] cpufreq: imx6q-cpufreq: Improve the logic of
 -EPROBE_DEFER handling

On 17-03-20, 12:38, Anson Huang wrote:
> Improve the -EPROBE_DEFER handling logic to simplify the code.
> 
> Signed-off-by: Anson Huang <Anson.Huang@....com>
> ---
>  drivers/cpufreq/imx6q-cpufreq.c | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/cpufreq/imx6q-cpufreq.c b/drivers/cpufreq/imx6q-cpufreq.c
> index 285b8e9..fdb2fff 100644
> --- a/drivers/cpufreq/imx6q-cpufreq.c
> +++ b/drivers/cpufreq/imx6q-cpufreq.c
> @@ -400,11 +400,9 @@ static int imx6q_cpufreq_probe(struct platform_device *pdev)
>  		ret = imx6q_opp_check_speed_grading(cpu_dev);
>  	}
>  	if (ret) {
> -		if (ret == -EPROBE_DEFER)
> -			goto out_free_opp;
> -
> -		dev_err(cpu_dev, "failed to read ocotp: %d\n",
> -			ret);
> +		if (ret != -EPROBE_DEFER)
> +			dev_err(cpu_dev, "failed to read ocotp: %d\n",
> +				ret);
>  		goto out_free_opp;
>  	}

Applied. Thanks.


-- 
viresh