lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Tue, 17 Mar 2020 09:30:43 +0100
From:   Adrian Reber <areber@...hat.com>
To:     Christian Brauner <christian.brauner@...ntu.com>,
        Eric Biederman <ebiederm@...ssion.com>,
        Pavel Emelyanov <ovzxemul@...il.com>,
        Oleg Nesterov <oleg@...hat.com>,
        Dmitry Safonov <0x7f454c46@...il.com>,
        Andrei Vagin <avagin@...il.com>
Cc:     linux-kernel@...r.kernel.org, Mike Rapoport <rppt@...ux.ibm.com>,
        Radostin Stoyanov <rstoyanov1@...il.com>,
        Adrian Reber <areber@...hat.com>,
        Michael Kerrisk <mtk.manpages@...il.com>,
        Arnd Bergmann <arnd@...db.de>,
        Cyrill Gorcunov <gorcunov@...nvz.org>,
        Thomas Gleixner <tglx@...utronix.de>
Subject: [PATCH 3/4] clone3: align structs and comments

To follow the existing style this commit aligns the comments and
structure settings to have the same look as before. Just with more
spaces.

Signed-off-by: Adrian Reber <areber@...hat.com>
---
 include/uapi/linux/sched.h | 72 +++++++++++++++++++-------------------
 kernel/fork.c              | 18 +++++-----
 2 files changed, 45 insertions(+), 45 deletions(-)

diff --git a/include/uapi/linux/sched.h b/include/uapi/linux/sched.h
index c9b36ef647cc..86387052de19 100644
--- a/include/uapi/linux/sched.h
+++ b/include/uapi/linux/sched.h
@@ -45,42 +45,42 @@
 #ifndef __ASSEMBLY__
 /**
  * struct clone_args - arguments for the clone3 syscall
- * @flags:        Flags for the new process as listed above.
- *                All flags are valid except for CSIGNAL and
- *                CLONE_DETACHED.
- * @pidfd:        If CLONE_PIDFD is set, a pidfd will be
- *                returned in this argument.
- * @child_tid:    If CLONE_CHILD_SETTID is set, the TID of the
- *                child process will be returned in the child's
- *                memory.
- * @parent_tid:   If CLONE_PARENT_SETTID is set, the TID of
- *                the child process will be returned in the
- *                parent's memory.
- * @exit_signal:  The exit_signal the parent process will be
- *                sent when the child exits.
- * @stack:        Specify the location of the stack for the
- *                child process.
- *                Note, @stack is expected to point to the
- *                lowest address. The stack direction will be
- *                determined by the kernel and set up
- *                appropriately based on @stack_size.
- * @stack_size:   The size of the stack for the child process.
- * @tls:          If CLONE_SETTLS is set, the tls descriptor
- *                is set to tls.
- * @set_tid:      Pointer to an array of type *pid_t. The size
- *                of the array is defined using @set_tid_size.
- *                This array is used to select PIDs/TIDs for
- *                newly created processes. The first element in
- *                this defines the PID in the most nested PID
- *                namespace. Each additional element in the array
- *                defines the PID in the parent PID namespace of
- *                the original PID namespace. If the array has
- *                less entries than the number of currently
- *                nested PID namespaces only the PIDs in the
- *                corresponding namespaces are set.
- * @set_tid_size: This defines the size of the array referenced
- *                in @set_tid. This cannot be larger than the
- *                kernel's limit of nested PID namespaces.
+ * @flags:              Flags for the new process as listed above.
+ *                      All flags are valid except for CSIGNAL and
+ *                      CLONE_DETACHED.
+ * @pidfd:              If CLONE_PIDFD is set, a pidfd will be
+ *                      returned in this argument.
+ * @child_tid:          If CLONE_CHILD_SETTID is set, the TID of the
+ *                      child process will be returned in the child's
+ *                      memory.
+ * @parent_tid:         If CLONE_PARENT_SETTID is set, the TID of
+ *                      the child process will be returned in the
+ *                      parent's memory.
+ * @exit_signal:        The exit_signal the parent process will be
+ *                      sent when the child exits.
+ * @stack:              Specify the location of the stack for the
+ *                      child process.
+ *                      Note, @stack is expected to point to the
+ *                      lowest address. The stack direction will be
+ *                      determined by the kernel and set up
+ *                      appropriately based on @stack_size.
+ * @stack_size:         The size of the stack for the child process.
+ * @tls:                If CLONE_SETTLS is set, the tls descriptor
+ *                      is set to tls.
+ * @set_tid:            Pointer to an array of type *pid_t. The size
+ *                      of the array is defined using @set_tid_size.
+ *                      This array is used to select PIDs/TIDs for
+ *                      newly created processes. The first element in
+ *                      this defines the PID in the most nested PID
+ *                      namespace. Each additional element in the array
+ *                      defines the PID in the parent PID namespace of
+ *                      the original PID namespace. If the array has
+ *                      less entries than the number of currently
+ *                      nested PID namespaces only the PIDs in the
+ *                      corresponding namespaces are set.
+ * @set_tid_size:       This defines the size of the array referenced
+ *                      in @set_tid. This cannot be larger than the
+ *                      kernel's limit of nested PID namespaces.
  * @timens_offset:      Pointer to an array of clock offsets for the
  *                      newly created process in a time namespaces.
  *                      This requires that a new time namespace has been
diff --git a/kernel/fork.c b/kernel/fork.c
index f80aca79d263..6e9acac1d347 100644
--- a/kernel/fork.c
+++ b/kernel/fork.c
@@ -2652,15 +2652,15 @@ noinline static int copy_clone_args_from_user(struct kernel_clone_args *kargs,
 		return -EINVAL;
 
 	*kargs = (struct kernel_clone_args){
-		.flags		= args.flags,
-		.pidfd		= u64_to_user_ptr(args.pidfd),
-		.child_tid	= u64_to_user_ptr(args.child_tid),
-		.parent_tid	= u64_to_user_ptr(args.parent_tid),
-		.exit_signal	= args.exit_signal,
-		.stack		= args.stack,
-		.stack_size	= args.stack_size,
-		.tls		= args.tls,
-		.set_tid_size	= args.set_tid_size,
+		.flags		    = args.flags,
+		.pidfd		    = u64_to_user_ptr(args.pidfd),
+		.child_tid	    = u64_to_user_ptr(args.child_tid),
+		.parent_tid	    = u64_to_user_ptr(args.parent_tid),
+		.exit_signal	    = args.exit_signal,
+		.stack		    = args.stack,
+		.stack_size	    = args.stack_size,
+		.tls		    = args.tls,
+		.set_tid_size	    = args.set_tid_size,
 		.timens_offset_size = args.timens_offset_size,
 	};
 
-- 
2.24.1

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ