linux-kernel - Re: [PATCH] Input: edt-ft5x06 - add fw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <40d823d7-5873-2a3c-9f49-87fdb7428061@puri.sm>
Date:   Tue, 17 Mar 2020 11:25:39 +0100
From:   Martin Kepplinger <martin.kepplinger@...i.sm>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     dmitry.torokhov@...il.com, m.felsch@...gutronix.de,
        mylene.josserand@...tlin.com, linux-input@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Input: edt-ft5x06 - add fw_version debugfs file to read

On 16.03.20 15:40, Andy Shevchenko wrote:
> On Mon, Mar 16, 2020 at 03:27:56PM +0100, Martin Kepplinger wrote:
>> Add simple fw_version file in debugfs to read the value from 0xa6
>> which is the firmware version.
> 
> 
> If you switch to regmap I²C API you will get this for free for all defined
> registers.
> 
> So, I highly recommend to consider above.
> 

I don't know all the devices and modes well enough if the current raw
read/write buffers always translate to (only) buf[0] being the register
address.

If you tell me I can assume just that, I'm happy to do a larger change
that completely does aways with the current raw buffers.

Otherwise:

Does is make sense to *add* just a few regmap calls but keep the current
i2c_transfer in place for the calls I'm not sure about? I could do that
in any case.

thanks!

                                   martin