linux-kernel - Re: [PATCH] Makefile: disallow data races on gcc-10 as well

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <nycvar.YFH.7.76.2003170240410.19500@cbobk.fhfr.pm>
Date:   Tue, 17 Mar 2020 02:41:21 +0100 (CET)
From:   Jiri Kosina <jikos@...nel.org>
To:     Sergei Trofimovich <slyfox@...too.org>
cc:     linux-kernel@...r.kernel.org,
        Masahiro Yamada <masahiroy@...nel.org>,
        Michal Marek <michal.lkml@...kovi.net>,
        linux-kbuild@...r.kernel.org
Subject: Re: [PATCH] Makefile: disallow data races on gcc-10 as well

On Tue, 17 Mar 2020, Jiri Kosina wrote:

> > The flag change happened at https://gcc.gnu.org/PR92046.
> > 
> > CC: Jiri Kosina <jkosina@...e.cz>
> > CC: Masahiro Yamada <masahiroy@...nel.org>
> > CC: Michal Marek <michal.lkml@...kovi.net>
> > CC: linux-kbuild@...r.kernel.org
> > Signed-off-by: Sergei Trofimovich <slyfox@...too.org>
> > ---
> >  Makefile | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/Makefile b/Makefile
> > index 171f2b004c8a..9696eb2cd5a1 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -714,6 +714,7 @@ endif
> >  
> >  # Tell gcc to never replace conditional load with a non-conditional one
> >  KBUILD_CFLAGS	+= $(call cc-option,--param=allow-store-data-races=0)
> > +KBUILD_CFLAGS	+= $(call cc-option,-fno-allow-store-data-races)
> 
> I have to say I can't really read gcc sources without major cerebral pain, 
> so let me me dense here: what happens to gcc<10 if you pass 
> -fno-allow-store-data-races to it?

Sorry, brainfart on my side, your patch is good :)

	Acked-by: Jiri Kosina <jkosina@...e.cz>

Thanks,

-- 
Jiri Kosina
SUSE Labs