linux-kernel - Re: [RESEND PATCH 1/3] mmc: host: Introduce the request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADBw62qPEO_iWpf5v3H-_xHCJRJ-6M8Y+jA1TTxPPdJvutCmSw@mail.gmail.com>
Date:   Tue, 17 Mar 2020 10:00:22 +0800
From:   Baolin Wang <baolin.wang7@...il.com>
To:     Ulf Hansson <ulf.hansson@...aro.org>
Cc:     Adrian Hunter <adrian.hunter@...el.com>,
        Orson Zhai <orsonzhai@...il.com>,
        Chunyan Zhang <zhang.lyra@...il.com>,
        Arnd Bergmann <arnd@...db.de>,
        "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [RESEND PATCH 1/3] mmc: host: Introduce the request_atomic() for
 the host

On Mon, Mar 16, 2020 at 7:48 PM Ulf Hansson <ulf.hansson@...aro.org> wrote:
>
> On Wed, 4 Mar 2020 at 08:42, Baolin Wang <baolin.wang7@...il.com> wrote:
> >
> > The SD host controller can process one request in the atomic context if
> > the card is nonremovable, which means we can submit next request in the
> > irq hard handler when using the MMC software queue to reduce the latency.
> > Thus this patch adds a new API request_atomic() for the host controller
> > and implement it for the SD host controller.
> >
> > Suggested-by: Adrian Hunter <adrian.hunter@...el.com>
> > Signed-off-by: Baolin Wang <baolin.wang7@...il.com>
> > ---
> >  drivers/mmc/host/sdhci.c | 27 +++++++++++++++++++--------
> >  drivers/mmc/host/sdhci.h |  1 +
> >  include/linux/mmc/host.h |  3 +++
> >  3 files changed, 23 insertions(+), 8 deletions(-)
>
> I think the code split of the changes in the series can be improved a
> bit, so I suggest you move the code around in the series to reach
> this:
>
> 1. A patch that adds the new host ops callback, combined with the
> change you have in patch3.
> 2. The sdhci core specific changes, from $subject patch.
> 3. The sdhci-sprd changes, as in patch2.
>
> Other than that, I think the code looks good to me, besides a minor
> comment on patch2, see separate reply.

Sure. Will do as you suggested. Thanks.

-- 
Baolin Wang