linux-kernel - Re: [PATCH] PCI: endpoint: functions/pci-epf-test: Fix compiler error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200317111732.GA25261@e121166-lin.cambridge.arm.com>
Date:   Tue, 17 Mar 2020 11:17:41 +0000
From:   Lorenzo Pieralisi <lorenzo.pieralisi@....com>
To:     Kishon Vijay Abraham I <kishon@...com>
Cc:     Bjorn Helgaas <bhelgaas@...gle.com>,
        Andrew Murray <amurray@...goodpenguin.co.uk>,
        Vidya Sagar <vidyas@...dia.com>, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] PCI: endpoint: functions/pci-epf-test: Fix compiler error

On Tue, Mar 17, 2020 at 01:17:19PM +0530, Kishon Vijay Abraham I wrote:
> Commit 812828eb5072 ("PCI: endpoint: Fix ->set_msix() to take BIR
> and offset as arguments") was created before adding deferred
> core initialization support in commit 5e50ee27d4a5 ("PCI: pci-epf-test:
> Add support to defer core initialization").
> However since deferred core initialization was merged before
> re-designing MSI-X support, it caused the following compiler error.
> 
> drivers/pci/endpoint/functions/pci-epf-test.c:697:12: error: ‘epf_test’ undeclared (first use in this function);
> 
> Fix the compilation error here.
> 
> Fixes: 812828eb5072 ("PCI: endpoint: Fix ->set_msix() to take BIR and offset as arguments")
> Reported-by: kbuild test robot <lkp@...el.com>
> Signed-off-by: Kishon Vijay Abraham I <kishon@...com>
> ---
> Lorenzo,
> 
> This patch can be squashed with
> "PCI: endpoint: Fix ->set_msix() to take BIR and offset as arguments"

Done, thank you very much.

Lorenzo

> Thanks
> Kishon
> 
>  drivers/pci/endpoint/functions/pci-epf-test.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/pci/endpoint/functions/pci-epf-test.c b/drivers/pci/endpoint/functions/pci-epf-test.c
> index eaf192be02bb..3b4cf7e2bc60 100644
> --- a/drivers/pci/endpoint/functions/pci-epf-test.c
> +++ b/drivers/pci/endpoint/functions/pci-epf-test.c
> @@ -660,6 +660,7 @@ static int pci_epf_test_set_bar(struct pci_epf *epf)
>  
>  static int pci_epf_test_core_init(struct pci_epf *epf)
>  {
> +	struct pci_epf_test *epf_test = epf_get_drvdata(epf);
>  	struct pci_epf_header *header = epf->header;
>  	const struct pci_epc_features *epc_features;
>  	struct pci_epc *epc = epf->epc;
> -- 
> 2.17.1
>