linux-kernel - Re: [PATCH] printk: handle blank console arguments passed in.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200317021736.syreot6rs5rtqsh3@shreyas_biamp.biamp.com>
Date:   Mon, 16 Mar 2020 19:17:36 -0700
From:   Shreyas Joshi <shreyas.joshi@...mp.com>
To:     Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
CC:     Steven Rostedt <rostedt@...dmis.org>,
        "pmladek@...e.com" <pmladek@...e.com>,
        "sergey.senozhatsky@...il.com" <sergey.senozhatsky@...il.com>,
        "shreyasjoshi15@...il.com" <shreyasjoshi15@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] printk: handle blank console arguments passed in.

Thanks! I thought If we put a warning there then it won’t print anything.
Please advise. I will send a new patch with the line wrapping to at most 75  once
I know if I need to change anything more. 

On Tue, Mar 17, 2020 at 11:01:44AM +0900, Sergey Senozhatsky wrote:
> On (20/03/16 21:39), Steven Rostedt wrote:
> [..]
> > > 
> > > diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c index ad4606234545..e9ad730991e0 100644
> > > --- a/kernel/printk/printk.c
> > > +++ b/kernel/printk/printk.c
> > > @@ -2165,7 +2165,10 @@ static int __init console_setup(char *str)
> > >  	char buf[sizeof(console_cmdline[0].name) + 4]; /* 4 for "ttyS" */
> > >  	char *s, *options, *brl_options = NULL;
> > >  	int idx;
> > > -
> > > +	if (str[0] == 0) {
> > > +		console_loglevel = 0;
> > > +		return 1;
> > 
> > Hmm, I wonder if this should produce a warning :-/
> 
> Hmm. Maybe the warning can seat in __setup() handling?
> There are 300+ places that theoretically can receive blank boot param
> 
> 	$ git grep "__setup(\".*=\"" | wc -l
> 	307
> 
> I'd assume that not all of those can handle blank params. At the same
> time, do we have cases when passing blank boot params is OK? E.g.
> "... root=/dev/sda1 foo= bar= ..."
> 
> 	-ss