linux-kernel - [PATCH v5 2/4] irqchip: xilinx: Fill error code when irq domain registration fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200317125600.15913-3-mubin.usman.sayyed@xilinx.com>
Date:   Tue, 17 Mar 2020 18:25:58 +0530
From:   Mubin Usman Sayyed <mubin.usman.sayyed@...inx.com>
To:     tglx@...utronix.de, jason@...edaemon.net, maz@...nel.org,
        michals@...inx.com, linux-arm-kernel@...ts.infradead.org
Cc:     linux-kernel@...r.kernel.org, sivadur@...inx.com,
        anirudh@...inx.com, Michal Simek <michal.simek@...inx.com>,
        Stefan Asserhall <stefan.asserhall@...inx.com>
Subject: [PATCH v5 2/4] irqchip: xilinx: Fill error code when irq domain registration fails

From: Michal Simek <michal.simek@...inx.com>

There is no ret filled in case of irq_domain_add_linear() failure.

Signed-off-by: Michal Simek <michal.simek@...inx.com>
Reviewed-by: Stefan Asserhall <stefan.asserhall@...inx.com>
---
 drivers/irqchip/irq-xilinx-intc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/irqchip/irq-xilinx-intc.c b/drivers/irqchip/irq-xilinx-intc.c
index 34593fa34c68..1d3d273309bd 100644
--- a/drivers/irqchip/irq-xilinx-intc.c
+++ b/drivers/irqchip/irq-xilinx-intc.c
@@ -228,6 +228,7 @@ static int __init xilinx_intc_of_init(struct device_node *intc,
 						  &xintc_irq_domain_ops, irqc);
 	if (!irqc->root_domain) {
 		pr_err("irq-xilinx: Unable to create IRQ domain\n");
+		ret = -EINVAL;
 		goto error;
 	}
 
-- 
2.25.0