linux-kernel - Re: [PATCH] tools/bootconfig: Makefile: Create destination directory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200317221516.25d92373a0194c9237b1ee38@kernel.org>
Date:   Tue, 17 Mar 2020 22:15:16 +0900
From:   Masami Hiramatsu <mhiramat@...nel.org>
To:     Adriana Kobylak <anoo@...ux.ibm.com>,
        Steven Rostedt <rostedt@...dmis.org>
Cc:     linux-kernel@...r.kernel.org, anoo@...ibm.com
Subject: Re: [PATCH] tools/bootconfig: Makefile: Create destination
 directory

On Mon, 16 Mar 2020 10:49:26 -0500
Adriana Kobylak <anoo@...ux.ibm.com> wrote:

> From: Adriana Kobylak <anoo@...ibm.com>
> 
> The DESTDIR path may not be available to the caller, such as
> compiling the bootconfig tool from a Yocto native recipe. Have
> the Makefile create the directory instead.

OK, this looks good to me.

Acked-by: Masami Hiramatsu <mhiramat@...nel.org>

Thanks!

> 
> Signed-off-by: Adriana Kobylak <anoo@...ibm.com>
> ---
>  tools/bootconfig/Makefile | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/bootconfig/Makefile b/tools/bootconfig/Makefile
> index a6146ac..470b6f0 100644
> --- a/tools/bootconfig/Makefile
> +++ b/tools/bootconfig/Makefile
> @@ -14,6 +14,7 @@ bootconfig: ../../lib/bootconfig.c main.c $(HEADER)
>  	$(CC) $(filter %.c,$^) $(CFLAGS) -o $@
>  
>  install: $(PROGS)
> +	install -d $(DESTDIR)$(bindir)
>  	install bootconfig $(DESTDIR)$(bindir)
>  
>  test: bootconfig
> -- 
> 1.8.3.1
> 


-- 
Masami Hiramatsu <mhiramat@...nel.org>