linux-kernel - Re: [PATCH v3 2/5] fs/filesystems.c: downgrade user-reachable WARN_ONCE() to pr_warn

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200318225524.GE2334@sol.localdomain>
Date:   Wed, 18 Mar 2020 15:55:24 -0700
From:   Eric Biggers <ebiggers@...nel.org>
To:     Jessica Yu <jeyu@...nel.org>
Cc:     Sasha Levin <sashal@...nel.org>, linux-kernel@...r.kernel.org,
        linux-fsdevel@...r.kernel.org, Alexei Starovoitov <ast@...nel.org>,
        stable@...r.kernel.org, Andrew Morton <akpm@...ux-foundation.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jeff Vander Stoep <jeffv@...gle.com>,
        Kees Cook <keescook@...omium.org>, NeilBrown <neilb@...e.com>
Subject: Re: [PATCH v3 2/5] fs/filesystems.c: downgrade user-reachable
 WARN_ONCE() to pr_warn_once()

On Wed, Mar 18, 2020 at 04:09:26PM +0100, Jessica Yu wrote:
> +++ Sasha Levin [17/03/20 22:30 +0000]:
> > Hi
> > 
> > [This is an automated email]
> > 
> > This commit has been processed because it contains a -stable tag.
> > The stable tag indicates that it's relevant for the following trees: all
> > 
> > The bot has tested the following trees: v5.5.9, v5.4.25, v4.19.109, v4.14.173, v4.9.216, v4.4.216.
> > 
> > v5.5.9: Build OK!
> > v5.4.25: Build OK!
> > v4.19.109: Build OK!
> > v4.14.173: Build OK!
> > v4.9.216: Failed to apply! Possible dependencies:
> >    41124db869b7 ("fs: warn in case userspace lied about modprobe return")
> > 
> > v4.4.216: Failed to apply! Possible dependencies:
> >    41124db869b7 ("fs: warn in case userspace lied about modprobe return")
> > 
> > 
> > NOTE: The patch will not be queued to stable trees until it is upstream.
> > 
> > How should we proceed with this patch?
> 
> Since commit 41124db869b7 was introduced v4.13, I guess we should
> change the stable tag to:
> 
> Cc: stable@...r.kernel.org # v4.13+
> 

It should use:

 Fixes: 41124db869b7 ("fs: warn in case userspace lied about modprobe return")
 Cc: <stable@...r.kernel.org> # v4.13+

I'll add it.