linux-kernel - Re: [PATCH] extcon: Mark extcon_get_edev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1ce81e60-8d71-de92-1295-93f9a59d0ada@samsung.com>
Date:   Wed, 18 Mar 2020 17:30:09 +0900
From:   Chanwoo Choi <cw00.choi@...sung.com>
To:     Mayank Rana <mrana@...eaurora.org>, myungjoo.ham@...sung.com
Cc:     linux-kernel@...r.kernel.org, jackp@...eaurora.org
Subject: Re: [PATCH] extcon: Mark extcon_get_edev_name() function as
 exported symbol

On 3/17/20 5:14 AM, Mayank Rana wrote:
> extcon_get_edev_name() function provides client driver to request
> extcon dev's name. If extcon driver and client driver are compiled
> as loadable modules, extcon_get_edev_name() function symbol is not
> visible to client driver. Hence mark extcon_find_edev_name() function
> as exported symbol.
> 
> Signed-off-by: Mayank Rana <mrana@...eaurora.org>
> ---
>  drivers/extcon/extcon.c | 1 +
>  include/linux/extcon.h  | 5 +++++
>  2 files changed, 6 insertions(+)
> 
> diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c
> index e055893..2dfbfec 100644
> --- a/drivers/extcon/extcon.c
> +++ b/drivers/extcon/extcon.c
> @@ -1406,6 +1406,7 @@ const char *extcon_get_edev_name(struct extcon_dev *edev)
>  {
>  	return !edev ? NULL : edev->name;
>  }
> +EXPORT_SYMBOL_GPL(extcon_get_edev_name);
>  
>  static int __init extcon_class_init(void)
>  {
> diff --git a/include/linux/extcon.h b/include/linux/extcon.h
> index 1b1d77e..fd183fb 100644
> --- a/include/linux/extcon.h
> +++ b/include/linux/extcon.h
> @@ -286,6 +286,11 @@ static inline struct extcon_dev *extcon_get_edev_by_phandle(struct device *dev,
>  {
>  	return ERR_PTR(-ENODEV);
>  }
> +
> +static inline const char *extcon_get_edev_name(struct extcon_dev *edev)
> +{
> +	return NULL;
> +}
>  #endif /* CONFIG_EXTCON */
>  
>  /*
> 

Applied it. Thanks.

-- 
Best Regards,
Chanwoo Choi
Samsung Electronics