linux-kernel - Re: Re: [PATCH] arm64: add blank after 'if'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 18 Mar 2020 09:30:41 +0000
From:   Catalin Marinas <catalin.marinas@....com>
To:     王文虎 <wenhu.wang@...o.com>
Cc:     Zheng Wei <wei.zheng@...o.com>, Hanjun Guo <guohanjun@...wei.com>,
        Enrico Weigelt <info@...ux.net>,
        Allison Randal <allison@...utok.net>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Yunfeng Ye <yeyunfeng@...wei.com>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        kernel@...o.com, Will Deacon <will@...nel.org>
Subject: Re: Re: [PATCH] arm64: add blank after 'if'

On Wed, Mar 18, 2020 at 01:32:28PM +0800, 王文虎 wrote:
> From: Will Deacon <will@...nel.org>
> Date: 2020-03-18 06:28:24
> To:  Zheng Wei <wei.zheng@...o.com>
> Cc:  Catalin Marinas <catalin.marinas@....com>,Hanjun Guo <guohanjun@...wei.com>,Enrico Weigelt <info@...ux.net>,Allison Randal <allison@...utok.net>,Greg Kroah-Hartman <gregkh@...uxfoundation.org>,Thomas Gleixner <tglx@...utronix.de>,Yunfeng Ye <yeyunfeng@...wei.com>,linux-arm-kernel@...ts.infradead.org,linux-kernel@...r.kernel.org,kernel@...o.com,wenhu.wang@...o.com
> Subject: Re: [PATCH] arm64: add blank after 'if'>On Fri, Mar 13, 2020 at 10:54:02PM +0800, Zheng Wei wrote:
> >> add blank after 'if' for armv8_deprecated_init()
> >> to make it comply with kernel coding style.
> >> 
> >> Signed-off-by: Zheng Wei <wei.zheng@...o.com>
> >> ---
> >>  arch/arm64/kernel/armv8_deprecated.c | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >> 
> >> diff --git a/arch/arm64/kernel/armv8_deprecated.c b/arch/arm64/kernel/armv8_deprecated.c
> >> index 7832b3216370..4cc581af2d96 100644
> >> --- a/arch/arm64/kernel/armv8_deprecated.c
> >> +++ b/arch/arm64/kernel/armv8_deprecated.c
> >> @@ -630,7 +630,7 @@ static int __init armv8_deprecated_init(void)
> >>  		register_insn_emulation(&cp15_barrier_ops);
> >>  
> >>  	if (IS_ENABLED(CONFIG_SETEND_EMULATION)) {
> >> -		if(system_supports_mixed_endian_el0())
> >> +		if (system_supports_mixed_endian_el0())
> >>  			register_insn_emulation(&setend_ops);
> >>  		else
> >>  			pr_info("setend instruction emulation is not supported on this system\n");
> >
> >(Catalin: I'm just acking these trivial typo/style fixes to get them out
> >of my inbox; do whatever you like with them ;)
> >
> >Acked-by: Will Deacon <will@...nel.org>
> >
> >Will
> 
> Shouldn't you have Cc trivial<trivial@...nel.org>?
> Asked-by: Wang Wenhu <wenhu.wang@...o.com>

I queued them already, they are in arm64 for-next/core. In the future,
it they could as well go in via trivial@...nel.org (as long as there are
no serious conflicts).

-- 
Catalin