linux-kernel - Re: [PATCH v3 4/5] usb: dwc2: convert to devm_platform_get_and_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f39917e0-2ee1-076c-c199-3e728ab063d2@synopsys.com>
Date:   Wed, 18 Mar 2020 10:40:17 +0000
From:   Minas Harutyunyan <Minas.Harutyunyan@...opsys.com>
To:     Dejin Zheng <zhengdejin5@...il.com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "rafael@...nel.org" <rafael@...nel.org>,
        "mathias.nyman@...el.com" <mathias.nyman@...el.com>,
        "bgolaszewski@...libre.com" <bgolaszewski@...libre.com>,
        "arnd@...db.de" <arnd@...db.de>,
        "jeffrey.t.kirsher@...el.com" <jeffrey.t.kirsher@...el.com>,
        "hdegoede@...hat.com" <hdegoede@...hat.com>,
        "treding@...dia.com" <treding@...dia.com>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "tomas.winkler@...el.com" <tomas.winkler@...el.com>,
        "suzuki.poulose@....com" <suzuki.poulose@....com>,
        "sergei.shtylyov@...entembedded.com" 
        <sergei.shtylyov@...entembedded.com>,
        "geert@...ux-m68k.org" <geert@...ux-m68k.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 4/5] usb: dwc2: convert to
 devm_platform_get_and_ioremap_resource



On 3/15/2020 6:05 PM, Dejin Zheng wrote:
> Use devm_platform_get_and_ioremap_resource() to simplify code, which
> contains platform_get_resource() and devm_ioremap_resource(), it also
> get the resource for use by the following code.
> 
> Signed-off-by: Dejin Zheng <zhengdejin5@...il.com>

Acked-by: Minas Harutyunyan <hminas@...opsys.com>

> ---
> v2 -> v3:
> 	- call the rename function devm_platform_get_and_ioremap_resource()
> 
> v1 -> v2:
> 	- add this patch for add some real users of this function.
>   
>   drivers/usb/dwc2/platform.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/dwc2/platform.c b/drivers/usb/dwc2/platform.c
> index 3c6ce09a6db5..8a68e89749d2 100644
> --- a/drivers/usb/dwc2/platform.c
> +++ b/drivers/usb/dwc2/platform.c
> @@ -392,8 +392,7 @@ static int dwc2_driver_probe(struct platform_device *dev)
>   		return retval;
>   	}
>   
> -	res = platform_get_resource(dev, IORESOURCE_MEM, 0);
> -	hsotg->regs = devm_ioremap_resource(&dev->dev, res);
> +	hsotg->regs = devm_platform_get_and_ioremap_resource(dev, 0, &res);
>   	if (IS_ERR(hsotg->regs))
>   		return PTR_ERR(hsotg->regs);
>   
>