linux-kernel - Re: [PATCH] KVM: nVMX: remove side effects from nested_vmx_exit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <803177a8-c5ef-ac5e-087b-52b09398d78c@redhat.com>
Date:   Wed, 18 Mar 2020 11:59:13 +0100
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Vitaly Kuznetsov <vkuznets@...hat.com>
Cc:     sean.j.christopherson@...el.com, linux-kernel@...r.kernel.org,
        kvm@...r.kernel.org
Subject: Re: [PATCH] KVM: nVMX: remove side effects from
 nested_vmx_exit_reflected

On 18/03/20 11:52, Vitaly Kuznetsov wrote:
> The only functional difference seems to be that we're now doing
> nested_mark_vmcs12_pages_dirty() in vmx->fail case too and this seems
> superfluous: we failed to enter L2 so 'special' pages should remain
> intact (right?) but this should be an uncommon case.
> 
> Reviewed-by: Vitaly Kuznetsov <vkuznets@...hat.com>

I'm not entirely sure if the PID could be written before the processor
decrees a vmfail.  It doesn't really hurt anyway as you say though.
Thanks for the review!

Paolo